Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Disqus support to Brick theme #347

Merged
merged 1 commit into from
Oct 29, 2015

Conversation

maxlambertini
Copy link
Contributor

Ok, hope to have got this merge stuff straight

@justinmayer
Copy link
Member

Thanks, Max. When you choose a name for a new feature branch, it's usually best to have it relate to the changes you plan to commit to that branch. For example, in this case you could have called it: disqus-support

Also, it'd be helpful to include the theme name in your commit message. Perhaps something like: Add Disqus support to Brick theme

@justinmayer justinmayer changed the title Committing Discus Stuff Add Disqus support to Brick theme Oct 29, 2015
justinmayer added a commit that referenced this pull request Oct 29, 2015
@justinmayer justinmayer merged commit a005e85 into getpelican:master Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants