Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed gum theme's banner and home button links #230

Merged
merged 1 commit into from
Jun 27, 2014
Merged

Fixed gum theme's banner and home button links #230

merged 1 commit into from
Jun 27, 2014

Conversation

syndbg
Copy link
Contributor

@syndbg syndbg commented Jun 27, 2014

Forgotten trailing slash in the href tags.

Forgotten trailing slash in the href tags.
justinmayer added a commit that referenced this pull request Jun 27, 2014
Fix gum theme's banner and home button links
@justinmayer justinmayer merged commit 1bcc0cf into getpelican:master Jun 27, 2014
@@ -68,14 +68,14 @@
<div class="row">

<header id="banner" class="body">
<h1><a href="{{ SITEURL }}">{{ SITENAME }} <strong>{{ SITESUBTITLE }}</strong></a></h1>
<h1><a href="{{ SITEURL }}\">{{ SITENAME }} <strong>{{ SITESUBTITLE }}</strong></a></h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be forward slashes and not backwards slashes?

http://en.wikipedia.org/wiki/Slash_(punctuation)#Networking

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I clearly missed that. Good catch, Kyle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Fixed in 8b443b5.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad guys! Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants