Open
Conversation
use realpath, always available, instead of python time python -c "import os,sys; print(os.path.realpath(sys.argv[1]))" service.yaml /Users/davidboon/Projects/outreach/devbase/evadnoob_fix_get-absolute-path-remove-python-dependency/service.yaml python -c "import os,sys; print(os.path.realpath(sys.argv[1]))" service.yaml 0.01s user 0.02s system 7% cpu 0.436 total time realpath service.yaml /Users/davidboon/Projects/outreach/devbase/evadnoob_fix_get-absolute-path-remove-python-dependency/service.yaml realpath service.yaml 0.00s user 0.00s system 15% cpu 0.013 total the exec to python to noticibly slower than using realpath from coreutils
malept
requested changes
Jun 30, 2025
Member
malept
left a comment
There was a problem hiding this comment.
For context:
Per Stack Exchange, realpath wasn't distributed with macOS until version 13, which probably wasn't supported by devbase when this implementation was written.
At a high level, this seems fine. However, a few things need to be resolved before this can be merged.
- Linting failed in CI.
- There's no reason for
get_absolute_pathto exist anymore, the one callsite can just callrealpathdirectly. - This only changes
scripts/devbase.sh, but this file is managed by Stencil (this module, in fact). So the changes need to also happen intemplates/scripts/devbase.sh.tplas well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use realpath, always available, instead of python
realpath in python
realpath from coreutils
the exec to python to noticibly slower than using realpath from
coreutils