Improve media displayed in widgets [BarcodeWidget + ArbitraryFileWidget + ExArbitraryFileWidget] #6964
+876
−848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grzesiek2010
force-pushed
the
COLLECT-6234_barcode2
branch
2 times, most recently
from
1a7aeac to
c4d4e48
Compare
grzesiek2010
changed the title
seadowg
requested changes
Nov 19, 2025
Member
seadowg
left a comment
seadowg
left a comment
There was a problem hiding this comment.
Some general comments on the structure before going any deeper!
collect_app/src/androidTest/java/org/odk/collect/android/feature/formentry/IntentGroupTest.kt
Outdated
Show resolved
Hide resolved
collect_app/src/main/java/org/odk/collect/android/widgets/barcode/BarcodeWidgetContent.kt
Outdated
Show resolved
Hide resolved
...ain/java/org/odk/collect/android/widgets/arbitraryfile/ArbitraryFileWidgetAnswerViewModel.kt
Outdated
Show resolved
Hide resolved
seadowg
requested changes
Dec 9, 2025
Member
seadowg
left a comment
seadowg
left a comment
There was a problem hiding this comment.
Looks great! Just one small tweak in the comments.
collect_app/src/main/java/org/odk/collect/android/widgets/TextWidgetAnswer.kt
Outdated
Show resolved
Hide resolved
grzesiek2010
force-pushed
the
COLLECT-6234_barcode2
branch
from
0dce671 to
d90c896
Compare
seadowg
approved these changes
Dec 19, 2025
|
Tested with success Verified on Android 10, 16 Verified cases:
|
|
Tested with success Verified on Android 10, 12 and 14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #6234
Blocked by #6925Why is this the best possible solution? Were any other approaches considered?
It's the continuation of #6925
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Please perform full regression testing on the three updated widgets:
BarcodeWidget,ArbitraryFileWidget, andExArbitraryFileWidget. They have been reworked, so they need to be tested thoroughly.Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew connectedAndroidTest(or./gradlew testLab) and confirmed all checks still passDateFormatsTest