Skip to content

Conversation

@grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Mar 22, 2022

What has been done to verify that this works as intended?

I reviewed implemented changes.

Why is this the best possible solution? Were any other approaches considered?

Not long time ago we decided that we shouldn't report RepeatsInFieldListException in firebase but it's still there: https://console.firebase.google.com/u/1/project/api-project-322300403941/crashlytics/app/android:org.odk.collect.android/issues/86ab1d9829929f39b117e831d788f498?time=last-ninety-days&versions=v2022.2-beta.0%20(4390);v2022.2-beta.1%20(4393)&sessionEventKey=6236E7C5021000011F406D9C4A71846B_1655556457296479999

The problem was that in AuditUtils we converted RepeatsInFieldListException to RuntimeException which should be reported so as a result RepeatsInFieldListException was reported too. I decided to get rid of rethrowing exceptions in AuditUtils at all since it's not important in that functionality, if it happens we can ignore it and the same exception will be handled in other places in the app if a form contains repeats in a field list.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

It doesn't need testing.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg seadowg requested a review from lognaturel April 4, 2022 10:54
@lognaturel
Copy link
Member

Looks good. Did an extra sanity check with https://docs.google.com/spreadsheets/d/159jGIYoZ5-f1JQTAWyfUFqk9-3k4mmbaM14KgbKbCbA/edit#gid=0 to make sure the dialog still looks as expected.

@lognaturel lognaturel merged commit e30d17b into getodk:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants