Do not report RepeatsInFieldListException as error in firebase [FIX[ #5069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done to verify that this works as intended?
I reviewed implemented changes.
Why is this the best possible solution? Were any other approaches considered?
Not long time ago we decided that we shouldn't report
RepeatsInFieldListExceptionin firebase but it's still there: https://console.firebase.google.com/u/1/project/api-project-322300403941/crashlytics/app/android:org.odk.collect.android/issues/86ab1d9829929f39b117e831d788f498?time=last-ninety-days&versions=v2022.2-beta.0%20(4390);v2022.2-beta.1%20(4393)&sessionEventKey=6236E7C5021000011F406D9C4A71846B_1655556457296479999The problem was that in
AuditUtilswe convertedRepeatsInFieldListExceptiontoRuntimeExceptionwhich should be reported so as a resultRepeatsInFieldListExceptionwas reported too. I decided to get rid of rethrowing exceptions inAuditUtilsat all since it's not important in that functionality, if it happens we can ignore it and the same exception will be handled in other places in the app if a form contains repeats in a field list.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It doesn't need testing.
Do we need any specific form for testing your changes? If so, please attach one.
No.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.