Handle invalid accuracyThreshold and unacceptableAccuracyThreshold #5041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seadowg
approved these changes
Feb 25, 2022
Member
seadowg
left a comment
seadowg
left a comment
There was a problem hiding this comment.
Nice failing test and a good solve!
seadowg
added
high priority
Contributor
|
Tested with success! Verified cases:
|
|
Tested with success! Verified on Androids: 10 and 11 |
seadowg
added a commit
that referenced
this pull request
Feb 25, 2022
Handle invalid accuracyThreshold and unacceptableAccuracyThreshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5039
What has been done to verify that this works as intended?
I've added automated tests.
Why is this the best possible solution? Were any other approaches considered?
It's just a fix, not much to discuss here.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
It should just fix the issue and have no side effects.
Do we need any specific form for testing your changes? If so, please attach one.
The form attached to the issue.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.