nginx: simplify enketo passthrough rewrites #992
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noted while working on #987
What has been done to verify that this works as intended?
Current tests continue to pass.
Why is this the best possible solution? Were any other approaches considered?
Using
rewrite ... lastand separating the two blocks means that passthrough URLs are now rewritten, and the entire config file re-evaluated for the new URLs:This is in contrast to the current approach using
rewrite ... break, which:and the
breakdirective is defined as:Which means that
break, unintuitively, allows continuing of the currentlocationblock.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)