Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx: skip frontend build in tests #813

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Dec 3, 2024

Pros

This significantly decreases test turnaround time.

Local results

./run-tests; time ./run-tests.sh
  • with this PR: 14 seconds
  • without this: 90 seconds

CI

It looks like CI time is also decreased from ~1m45 to ~1m

Cons

  • complicates build script (build-frontend.sh)

What has been done to verify that this works as intended?

CI.

Why is this the best possible solution? Were any other approaches considered?

Other options might be to:

  • override the client directory in test envs
  • use a different dockerfile in tests
  • override build-frontend.sh in test envs

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No effect.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

This significantly decreases test turnaround time.

Local results (`./run-tests; time ./run-tests.sh`):

* with this PR: 14 seconds
* without this: 90 seconds

Cons:

* complicates build script (`build-frontend.sh`)
@alxndrsn alxndrsn marked this pull request as ready for review December 3, 2024 06:40
@alxndrsn alxndrsn changed the base branch from master to next December 3, 2024 06:43
@alxndrsn alxndrsn merged commit 5bb4def into getodk:next Dec 5, 2024
1 check passed
@alxndrsn alxndrsn deleted the faster-test-turnaround branch December 5, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants