Fix test of DatasetRow that can fail during certain times of day #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least on my machine, new Date().toISOString() returns an ISO string in UTC. During certain hours of the day, the date in UTC is different from the date in my time zone. That's normally no issue for the DateTime component, which formats date/times in the user's time zone. However, because the test removes the time part from the ISO string, the string becomes a date from tomorrow. The test fails because the <time> element shows "tomorrow", not "today". I don't think we actually need to remove the time part for the test to work. When I stop removing the time part, the test passes throughout the day.
Member
Author
|
Another way to solve this would be to mock the time zone: setLuxon({ defaultZoneName: 'UTC' });Then Luxon will act as if the machine is in UTC, causing the UTC date and the date in the local time zone to match. You could also check the |
sadiqkhoja
approved these changes
Jan 25, 2023
Contributor
sadiqkhoja
left a comment
sadiqkhoja
left a comment
There was a problem hiding this comment.
it was failing for me earlier, it's working now. I must have been doing something wrong.
sadiqkhoja
added a commit
to sadiqkhoja/central-frontend
that referenced
this pull request
Dec 31, 2024
sadiqkhoja
added a commit
to sadiqkhoja/central-frontend
that referenced
this pull request
Dec 31, 2024
sadiqkhoja
added a commit
to sadiqkhoja/central-frontend
that referenced
this pull request
Jan 6, 2025
sadiqkhoja
added a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for notes. It's a funny issue!