Features: Delete dataset #1736
Merged
Features: Delete dataset #1736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadiqkhoja
changed the title
sadiqkhoja
changed the base branch from
master
to
features/delete-datasets-and-properties
sadiqkhoja
force-pushed
the
features/delete-datasets
branch
from
3399c5a to
d9fddda
Compare
sadiqkhoja
commented
Jan 22, 2026
ktuite
approved these changes
Jan 23, 2026
test/integration/api/datasets.js
Outdated
| }); | ||
| })); | ||
|
|
||
| it('should not entities for deleted dataset', testService(async (service, container) => { |
Member
There was a problem hiding this comment.
Missing word here, probably "create"?
Or it could say something like "should not create entities from a submission in a deleted dataset" to differentiate from just creating an entity via the API.
Suggested change
| it('should not entities for deleted dataset', testService(async (service, container) => { | |
| it('should not create entities for deleted dataset', testService(async (service, container) => { |
test/integration/api/datasets.js
Outdated
|
|
||
| await exhaust(container); | ||
|
|
||
| // TODO: assert that entity is not created. |
Member
There was a problem hiding this comment.
You could check the audit log on the submission to see that there was an entity.error event and no change to the expected number of entities in the dataset
test/integration/api/datasets.js
Outdated
| // TODO: assert that entity is not created. | ||
| })); | ||
|
|
||
| it('should reject if there is a Form updating the dataset', testService(async (service) => { |
Member
There was a problem hiding this comment.
Could be moved up near the test "should reject if there is a Form updating the dataset"
Suggested change
| it('should reject if there is a Form updating the dataset', testService(async (service) => { | |
| it('should reject if there is a Form consuming the dataset', testService(async (service) => { |
sadiqkhoja
merged commit 2802ba5
into
getodk:features/delete-datasets-and-properties
6 checks passed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards getodk/central#1337
Changes:
deletedquery parameter to the List datasets of a project API that returns deleted datasetsWhat has been done to verify that this works as intended?
All tests are passing
Why is this the best possible solution? Were any other approaches considered?
I had added a logic to check the dataset trash for duplicate dataset before creating a new one with the same name, but we discussed to remove that part because that would be noise or maybe that's exactly what users want to do.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
No
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
To be added to the feature branch.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes