OData-style filter for geoapis #1717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brontolosone
force-pushed
the
1396_odata-queryparams-for-geoapis
branch
2 times, most recently
from
7dfaefb to
73490a5
Compare
brontolosone
changed the title
2 tasks
sadiqkhoja
reviewed
Dec 16, 2025
Contributor
|
Do you plan to update API docs in a separate PR? |
brontolosone
force-pushed
the
1396_odata-queryparams-for-geoapis
branch
from
73490a5 to
114f947
Compare
brontolosone
force-pushed
the
1396_odata-queryparams-for-geoapis
branch
from
114f947 to
085edad
Compare
Contributor
Author
|
@sadiqkhoja a bunch of things have changed, please have another look! |
sadiqkhoja
approved these changes
Dec 20, 2025
Contributor
|
looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#1396
Additionally, limits the number of allowed path specifications to 1 (if you want to geo-analyze more form paths, you'll have to construct more URLs, one per form path).
Additionally, this removes now-unused parameter validation.
What has been done to verify that this works as intended?
Tests (which needed adapting).
Why is this the best possible solution? Were any other approaches considered?
N/A
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
N/A
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Yes. API documentation is to come once this passes muster.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes