Skip to content

Conversation

@CarstenGrohmann
Copy link
Contributor

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

This PR fixes spelling mistakes and errors in the Python examples:

e.g. missing comma in

nikola/docs/manual.rst

Lines 599 to 603 in e09ea79

METADATA_MAPPING = {
"rest_docinfo": {"summary": "description", "modified": "updated"},
"markdown_metadata": {"summary": "description", "modified": "updated"}
"html_metadata": {"summary": "description", "modified": "updated"}
}

for you.

DON'T READ THIS MANUAL. IF YOU NEED TO READ IT I FAILED, JUST USE THE THING.
DONT READ THIS MANUAL. IF YOU NEED TO READ IT I FAILED, JUST USE THE THING.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plain ASCII quotes are not “spelling mistakes”. Changing them to fancy quotes has no benefit and only complicates reading this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree that plain ASCII quotes aren't spelling mistakes. My main goal with the curly quotes was to make the quote style consistent throughout the document (some sections already used “fancy” quotes, others used straight ones).
If you prefer to keep ASCII quotes everywhere for simplicity and consistency, that's totally fine with me—happy to revert those changes.
Should I drop the curly-quote part and keep only the actual typo fixes, or would you like me to push a new version without them?


To add these metadata fields to all new posts by default, you can set the
variable ``ADDITIONAL_METADATA`` in your configuration. For example, you can
variable ``ADDITIONAL_METADATA`` in your configuration. For example, you can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double spacing is not wrong either and it does not show up in HTML.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, not in HTML, but when manually editing the rst file.
Keep or undo?

.. code:: python
# POSTS and PAGES contains (wildcard, destination, template) tuples.
# POSTS and PAGES contain (wildcard, destination, template) tuples.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you’re making changes to output samples, the changes should also be applied to the codebase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43cbb20

docs/manual.rst Outdated
Comment on lines 808 to 809
this behavior with your ``conf.py``: ``INDEX_TEASERS`` defines whether the index
page should display the whole contents or only teasers. ``FEED_TEASERS``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this behavior with your ``conf.py``: ``INDEX_TEASERS`` defines whether the index
page should display the whole contents or only teasers. ``FEED_TEASERS``
this behavior with your ``conf.py``: ``INDEX_TEASERS`` defines whether index
pages should display the whole contents or only teasers. ``FEED_TEASERS``

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43cbb20

docs/manual.rst Outdated
THEME_CONFIG = {
DEFAULT_LANG: {
# Show the latest featured post in a large box, with the previewimage as its background.
# Show the latest featured post in a large box, with the preview image as its background.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo, this is the name of the meta field.

Suggested change
# Show the latest featured post in a large box, with the preview image as its background.
# Show the latest featured post in a large box, with the previewimage as its background.

Copy link
Contributor Author

@CarstenGrohmann CarstenGrohmann Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo in 43cbb20

Perhaps we should add some quotation marks here to make it clear to casual readers that this is a metadata field:

            # Show the latest featured post in a large box, with the ``previewimage`` as its background.

docs/manual.rst Outdated
# Strip HTML from featured post text.
'featured_strip_html': True,
# Contents of the sidebar, If empty, the sidebar is not displayed.
# Contents of the sidebar, if empty, the sidebar is not displayed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Contents of the sidebar, if empty, the sidebar is not displayed.
# Contents of the sidebar. If empty, the sidebar is not displayed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 43cbb20

docs/manual.rst Outdated
The next unit for organizing your content is categories. A post can have only one category, specified with the ``category`` meta tag. They are displayed alongside tags. You can have categories and tags with the same name (categories’ RSS and HTML files are prefixed with ``cat_`` by default).

Categories are handy to organize different parts of your blog, parts that are about different topics. Unlike tags, which you should have tens (hundreds?) of, the list of categories should be shorter.
Categories are handy to organize different parts of your blog, parts that are about different topics. Unlike tags, for which you should have tens or hundreds, the list of categories should be shorter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo. for does not seem correct here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo in 43cbb20

docs/manual.rst Outdated
You can pass a different configuration file by using the ``--conf`` command line switch.

The default ``conf.py`` you get with Nikola should be fairly complete, and is quite
The default ``conf.py`` you get with Nikola should be fairly complete and is quite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo in 43cbb20

docs/manual.rst Outdated
You have to install those yourself or through a package manager.
You can also share plugins you created with the community! Visit the
And you can also share plugins you created with the community! Visit the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo in 43cbb20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants