-
Notifications
You must be signed in to change notification settings - Fork 466
doc: correct spelling mistakes and Python errors #3870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| for you. | ||
|
|
||
| DON'T READ THIS MANUAL. IF YOU NEED TO READ IT I FAILED, JUST USE THE THING. | ||
| DON’T READ THIS MANUAL. IF YOU NEED TO READ IT I FAILED, JUST USE THE THING. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plain ASCII quotes are not “spelling mistakes”. Changing them to fancy quotes has no benefit and only complicates reading this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree that plain ASCII quotes aren't spelling mistakes. My main goal with the curly quotes was to make the quote style consistent throughout the document (some sections already used “fancy” quotes, others used straight ones).
If you prefer to keep ASCII quotes everywhere for simplicity and consistency, that's totally fine with me—happy to revert those changes.
Should I drop the curly-quote part and keep only the actual typo fixes, or would you like me to push a new version without them?
|
|
||
| To add these metadata fields to all new posts by default, you can set the | ||
| variable ``ADDITIONAL_METADATA`` in your configuration. For example, you can | ||
| variable ``ADDITIONAL_METADATA`` in your configuration. For example, you can |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double spacing is not wrong either and it does not show up in HTML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right, not in HTML, but when manually editing the rst file.
Keep or undo?
| .. code:: python | ||
| # POSTS and PAGES contains (wildcard, destination, template) tuples. | ||
| # POSTS and PAGES contain (wildcard, destination, template) tuples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you’re making changes to output samples, the changes should also be applied to the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 43cbb20
docs/manual.rst
Outdated
| this behavior with your ``conf.py``: ``INDEX_TEASERS`` defines whether the index | ||
| page should display the whole contents or only teasers. ``FEED_TEASERS`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| this behavior with your ``conf.py``: ``INDEX_TEASERS`` defines whether the index | |
| page should display the whole contents or only teasers. ``FEED_TEASERS`` | |
| this behavior with your ``conf.py``: ``INDEX_TEASERS`` defines whether index | |
| pages should display the whole contents or only teasers. ``FEED_TEASERS`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 43cbb20
docs/manual.rst
Outdated
| THEME_CONFIG = { | ||
| DEFAULT_LANG: { | ||
| # Show the latest featured post in a large box, with the previewimage as its background. | ||
| # Show the latest featured post in a large box, with the preview image as its background. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo, this is the name of the meta field.
| # Show the latest featured post in a large box, with the preview image as its background. | |
| # Show the latest featured post in a large box, with the previewimage as its background. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo in 43cbb20
Perhaps we should add some quotation marks here to make it clear to casual readers that this is a metadata field:
# Show the latest featured post in a large box, with the ``previewimage`` as its background.
docs/manual.rst
Outdated
| # Strip HTML from featured post text. | ||
| 'featured_strip_html': True, | ||
| # Contents of the sidebar, If empty, the sidebar is not displayed. | ||
| # Contents of the sidebar, if empty, the sidebar is not displayed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Contents of the sidebar, if empty, the sidebar is not displayed. | |
| # Contents of the sidebar. If empty, the sidebar is not displayed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 43cbb20
docs/manual.rst
Outdated
| The next unit for organizing your content is categories. A post can have only one category, specified with the ``category`` meta tag. They are displayed alongside tags. You can have categories and tags with the same name (categories’ RSS and HTML files are prefixed with ``cat_`` by default). | ||
|
|
||
| Categories are handy to organize different parts of your blog, parts that are about different topics. Unlike tags, which you should have tens (hundreds?) of, the list of categories should be shorter. | ||
| Categories are handy to organize different parts of your blog, parts that are about different topics. Unlike tags, for which you should have tens or hundreds, the list of categories should be shorter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo. for does not seem correct here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo in 43cbb20
docs/manual.rst
Outdated
| You can pass a different configuration file by using the ``--conf`` command line switch. | ||
|
|
||
| The default ``conf.py`` you get with Nikola should be fairly complete, and is quite | ||
| The default ``conf.py`` you get with Nikola should be fairly complete and is quite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo in 43cbb20
docs/manual.rst
Outdated
| You have to install those yourself or through a package manager. | ||
| You can also share plugins you created with the community! Visit the | ||
| And you can also share plugins you created with the community! Visit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Undo in 43cbb20
d285587 to
43cbb20
Compare
Pull Request Checklist
Description
This PR fixes spelling mistakes and errors in the Python examples:
e.g. missing comma in
nikola/docs/manual.rst
Lines 599 to 603 in e09ea79