Add section path 2738

[h4ckninja]

Pull Request Checklist

• I’ve read the guidelines for contributing.
• I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
• I tested my changes.

Description

Fixes #2738.

[Kwpolska]

It looks like your commit was misattributed. Please add the e-mail address you used for this commit to your GitHub profile so your commits will appear as yours.

[Kwpolska]

That doesn’t make much sense. Did you mean SECTION_PATH / SECTION_NAME / rss.xml? (Otherwise, there would be only one RSS file for all sections)

[Kwpolska]

Don’t concatenate, make it a list of two elements.

[felixfontein]

You need to write self.site.config['SECTION_PATH'](lang) to make it translatable.

You can take a look at tags.py to see how this could be done correctly:

    def get_path(self, classification, lang, dest_type='page'):
        """Return a path for the given classification."""
        return [_f for _f in [
            self.site.config['TAG_PATH'](lang),
            self.slugify_tag_name(classification, lang)] if _f], 'auto'

So it should be:

        result = [_f for _f in [self.site.config['SECTION_PATH'](lang), section] if _f]

[felixfontein]

SECTION_PATH is not translatable in your implementation. You need to add it to nikola/nikola.py, both to the default config and to TRANSLATABLE_SETTINGS. Then, when you use it, you have to provide the language (see comment below). (Search for TAG_PATH in nikola.py to see how it is done.)

[felixfontein]

You need to write self.site.config['SECTION_PATH'](lang) to make it translatable.

You can take a look at tags.py to see how this could be done correctly:

    def get_path(self, classification, lang, dest_type='page'):
        """Return a path for the given classification."""
        return [_f for _f in [
            self.site.config['TAG_PATH'](lang),
            self.slugify_tag_name(classification, lang)] if _f], 'auto'

So it should be:

        result = [_f for _f in [self.site.config['SECTION_PATH'](lang), section] if _f]

[felixfontein]

Also, you need to update AUTHORS.txt :)

[h4ckninja]

It looks like your commit was misattributed. Please add the e-mail address you used for this commit to your GitHub profile so your commits will appear as yours.

Weird, I had that fixed at one point. But should be fixed now. Thanks.

Also, you need to update AUTHORS.txt :)

I didn't because it was such a minor change, but okay.

Did you mean SECTION_PATH / SECTION_NAME / rss.xml?

Yes, that was a typo. I'll fix that.

[felixfontein]

If you'd fix a typo or a small bug, it might be too minor, but this is a new feature after all, even if somewhat minor :)

[h4ckninja]

Okay, I believe I've addressed the comments.

[Kwpolska]

LGTM!

[felixfontein]

LGTM too!

[felixfontein]

Ok, one little thing: you should put yourself at the correct (alphabetically sorted) place ;-) But we (or at least Kwpolska) can do that during merging.

[Kwpolska]

Fixed that.

[Kwpolska]

Thanks for contributing to Nikola! 🎉