-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change all instances of 'story' to 'page' #2518
Conversation
This commit replaces all instances of 'story' or 'stories' with 'page' or 'pages'. The settings STORY_INDEX and COMMENTS_IN_STORIES are now PAGE_INDEX and COMMENTS_IN_PAGES see getnikola#1891
@@ -88,14 +88,14 @@ one of the existing ones. | |||
You can do doctests, you can do unit tests, you can do integration tests. There is support | |||
for all of them. | |||
|
|||
Posts and Stories | |||
Posts and Pages | |||
----------------- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Underline needs to match new title length.
|
||
You can create the page's files manually or use the ``new_post`` command | ||
with the ``-p`` option, which will place the files in the folder that | ||
has ``use_in_feed`` set to False. | ||
|
||
In some places (including default directories and templates), pages are called |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d prefer this explainer to be left in.
@@ -1 +1,185 @@ | |||
../creating-a-site.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your git client seems to have broken symlinks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on Windows. How do I fix that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can’t; we will if we go ahead with this.
@@ -378,7 +378,7 @@ class Importer(Command): | |||
|
|||
process_data can branch into: | |||
|
|||
import_story (may use import_file and save_post) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s not break an internal API here and undo this one.
To do (by us):
@ralsina, mind reviewing this, too? |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@christianp Alright, I had some time to fix stuff and this now looks better. Please add an entry to CHANGES.txt and your name to AUTHORS.txt. You might also want to see how it looks now. Thanks for contributing to Nikola — we hope you’ll stay with us for longer! I left @ralsina (and anyone else): Reviews welcome. |
@Kwpolska sorry, I have absolutely no Nikola time for personal reasons until next week at least. Anything has my +1 I'd rather have master break a bit than letting contributions wither. |
@ralsina Okay, I’ll merge this now, but please look through the files changed whenever you have a while (no rush). |
This commit replaces all instances of 'story' or 'stories' with 'page' or 'pages'.
The settings STORY_INDEX and COMMENTS_IN_STORIES are now PAGE_INDEX and COMMENTS_IN_PAGES
see #1891