fix RTL line block issues (fixes #1399) #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| html[dir="rtl"] div.line-block div.line-block { | ||
| margin-top: 0 ; | ||
| margin-bottom: 0 ; | ||
| margin-right: 1.5em } |
There was a problem hiding this comment.
Are you sure this is enough to override the left margin of 1.5 em? To me, it sounds like it will have that margin on both sides.
margin-left: 0; perchance?
Kwpolska
changed the title
|
Should be good. Thanks for your contribution! I’ll add you to AUTHORS.txt and add a note in CHANGES.txt. |
Kwpolska
added a commit
that referenced
this pull request
Sep 4, 2014
fix RTL line block issues (fixes #1399)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RST line blocks are not working properly for rtl (right-to-left) languages in (at least) the bootstrap theme. The CSS for those indentations (div.line-block div.line-block) in rst.css indents from margin-left regardless of whether the document is rtl (right-to-left). These changes add a css entry to rst.css in both base/assets/css/rst.css and themes/bootstrap3/assets/css/rst.css to change the direction of indentation for RST line blocks for right-to-left documents.
Fixes #1399.