Fix 'ValueError: invalid literal for int() with base 10' when parsing a float in JSON data#27
Closed
lukemorrill wants to merge 1 commit intogetmoto:mainfrom
lukemorrill:main
Closed
Fix 'ValueError: invalid literal for int() with base 10' when parsing a float in JSON data#27lukemorrill wants to merge 1 commit intogetmoto:mainfrom lukemorrill:main
lukemorrill wants to merge 1 commit intogetmoto:mainfrom
lukemorrill:main
Conversation
… a float in JSON data
Collaborator
|
Hi @lukemorrill! This fix didn't work for me I'm afraid. I've opened #28 with some sample documents that contain floats, and the work required to make them pass. Can you share an example document that failed for you, where your fix did work? I'd like to verify that also works against my fix before merging. |
Author
|
It had fixed a unit test for a complex application, but I'm not seeing it work for a simple example. I'll dig a little deeper and try to understand why it worked in one case and not the other. |
Collaborator
|
This should now be fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into this error when using moto and S3 select queries to retrieve float values from nested JSON data stored in a moto S3 bucket. This change resolved the issue for me.