Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for infinite loop when WaitTimeSeconds was set to 0 #969

Merged
merged 2 commits into from
Jun 1, 2017

Conversation

Brett55
Copy link
Contributor

@Brett55 Brett55 commented Jun 1, 2017

There was a bug when WaitTimeSeconds was set to zero causing an infinite loop if no messages came in. Added two unit tests

Bug fix for infinite loop when WaitTimeSeconds was set to 0
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0007%) to 93.637% when pulling 2a8b5d5 on Brett55:master into 8f7f306 on spulec:master.

1 similar comment
@coveralls
Copy link

coveralls commented Jun 1, 2017

Coverage Status

Coverage increased (+0.0007%) to 93.637% when pulling 2a8b5d5 on Brett55:master into 8f7f306 on spulec:master.

@JackDanger
Copy link
Collaborator

Fantastic work, @Brett55!

@JackDanger JackDanger merged commit ad36dbf into getmoto:master Jun 1, 2017
@JackDanger
Copy link
Collaborator

Merged, thank you for your contribution!

@Brett55
Copy link
Contributor Author

Brett55 commented Jun 1, 2017

@JackDanger How do I bump the version so I can install it locally with new changes?

@JackDanger
Copy link
Collaborator

JackDanger commented Jun 1, 2017

@JackDanger How do I bump the version so I can install it locally with new changes?

@Brett55 If you just need it installed locally this'll work: pip install -U git+https://github.com/spulec/moto.git@master

If you need it to work with setup.py you'll have to google for 'process dependency links'. I'm unsure how to read the latest code with requirements.txt but I'm sure there's a way.

@Brett55
Copy link
Contributor Author

Brett55 commented Jun 1, 2017 via email

@JackDanger
Copy link
Collaborator

@Brett55 Historically, not often. The 1.0.0 release just happened and I bet @spulec will release another one in the next month or two but it's not something we do after each bugfix. Personally, I use setup.py and --process-dependency-links and have my primary app use the latest master commit of Moto at all times. I recommend that approach until the next stable release.

@Brett55
Copy link
Contributor Author

Brett55 commented Jun 1, 2017 via email

@JackDanger
Copy link
Collaborator

I really haven't. There's an issue on Pip about un-deprecating it: pypa/pip#4187

@spulec
Copy link
Collaborator

spulec commented Jun 4, 2017

@Brett55 I've released 1.0.1 (I'm trying to get better about releasing versions more often)

@Brett55
Copy link
Contributor Author

Brett55 commented Jun 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants