-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for infinite loop when WaitTimeSeconds was set to 0 #969
Conversation
- Added 2 unit tests
Bug fix for infinite loop when WaitTimeSeconds was set to 0
1 similar comment
Fantastic work, @Brett55! |
Merged, thank you for your contribution! |
@JackDanger How do I bump the version so I can install it locally with new changes? |
@Brett55 If you just need it installed locally this'll work: If you need it to work with setup.py you'll have to google for 'process dependency links'. I'm unsure how to read the latest code with requirements.txt but I'm sure there's a way. |
When does pypi typically get updated?
…On Thu, Jun 1, 2017 at 11:26 AM, Jack Danger ***@***.***> wrote:
@JackDanger <https://github.com/jackdanger> How do I bump the version so
I can install it locally with new changes?
If you just need it installed locally this'll work: pip install -U git+
***@***.***
If you need it to work with setup.py you'll have to google for 'process
dependency links'. I'm unsure how to read the latest code with
requirements.txt but I'm sure there's a way.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#969 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGsE2XOHQWtLKagZKMI2fKkCDlj2lg1vks5r_vQ7gaJpZM4NtL_X>
.
|
@Brett55 Historically, not often. The 1.0.0 release just happened and I bet @spulec will release another one in the next month or two but it's not something we do after each bugfix. Personally, I use |
Thanks, I'm familiar with --process-dependency-links, I've noticed its
deprecated, have you found any other alternatives?
…On Thu, Jun 1, 2017 at 12:10 PM, Jack Danger ***@***.***> wrote:
@Brett55 <https://github.com/brett55> Historically, not often. The 1.0.0
release just happened and I bet @spulec <https://github.com/spulec> will
release another one in the next month or two but it's not something we do
after each bugfix. Personally, I use setup.py and
--process-dependency-links and have my primary app use the latest master
commit of Moto at all times. I recommend that approach until the next
stable release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#969 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGsE2WTRgO7P_0HcEcCgiUciKRhDLBfTks5r_v6mgaJpZM4NtL_X>
.
|
I really haven't. There's an issue on Pip about un-deprecating it: pypa/pip#4187 |
@Brett55 I've released |
Thanks!
|
There was a bug when WaitTimeSeconds was set to zero causing an infinite loop if no messages came in. Added two unit tests