Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Add EventBridge Notification for DeleteObject #7420

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

MikiPWata
Copy link
Contributor

@MikiPWata MikiPWata commented Mar 4, 2024

PR for DeleteObject in #7363

  • send EventBridge notification when Object is Deleted(for buckets that are versioned and not versioned)
  • added a test case for sending eventbridge notification

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.80%. Comparing base (9aef694) to head (139a3fe).
Report is 79 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7420      +/-   ##
==========================================
- Coverage   95.88%   95.80%   -0.08%     
==========================================
  Files         843      849       +6     
  Lines       82578    83668    +1090     
==========================================
+ Hits        79178    80162     +984     
- Misses       3400     3506     +106     
Flag Coverage Δ
servertests 32.30% <0.00%> (-0.23%) ⬇️
unittests 95.77% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MikiPWata MikiPWata marked this pull request as ready for review March 7, 2024 00:47
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for adding this @MikiPWata!

@bblommers bblommers added this to the 5.0.3 milestone Mar 7, 2024
@bblommers bblommers merged commit ef76533 into getmoto:master Mar 7, 2024
39 checks passed
Copy link
Contributor

github-actions bot commented Mar 7, 2024

This is now part of moto >= 5.0.3.dev50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants