-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Support All AWS Partitions #6412
Feat: Support All AWS Partitions #6412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joel-aws, thanks for the PR! Please see my comment
I realized I was querying an old |
Codecov Report
@@ Coverage Diff @@
## master #6412 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 799 799
Lines 77906 77917 +11
=======================================
+ Hits 74920 74932 +12
+ Misses 2986 2985 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks again @joel-aws!
This is now part of moto >= 4.1.12.dev36 |
Hi @joel-aws! Another followup question/issue around this feature: The suggested alternative way to get this region-information is to use the SSM parameter store instead, and I am looking into a feasible implementation for Moto. The main problem I am running into is that these ISO regions are not exposed in the SSM parameter store. The US-gov and China regions are exposed, so it would make sense to me if the ISO-regions are also part of it. Is that something you can raise internally, to see if that information can be included/exposed? I understand that it's probably an entirely different team responsible for this, but I'm assuming that a request from an internal employee would hold more weight than a random support ticket from a regular user 🙂 |
@bblommers -- apologies for the delay in responding! I am now posing this question internally... On the flip side, we value customer input via service tickets. If you haven't already opened one, could you do that and share the ticket # ? |
No problem @joel-aws - thanks for getting back to me. I haven't been on top of this either, to be honest - I only just opened a ticket now, nr |
This PR extends support of moto to all AWS Partitions.
One can see all Partitions, Regions, and DNS Suffixes with:
curl https://raw.githubusercontent.com/boto/botocore/develop/botocore/data/endpoints.json | jq '.partitions[] | [.partitionName, .partition, .regions, .dnsSuffix]'