Conversation
… multipart fields Fixes #107 Changes: - Modified handleMultipartSingleFile to iterate through all parts instead of only the first - Body fields are now correctly captured regardless of order - Maintains strict validation (rejects multiple files, wrong fieldnames) - All existing tests pass (backward compatible) Added tests: - Upload file with body fields - Upload file when body fields come first (order independence) - Reject multiple files on same field - Reject file with wrong fieldname Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add .worktrees directory to gitignore to prevent git worktree directories from being tracked in the repository. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit 8f14f15
☁️ Nx Cloud last updated this comment at |
…tMQ 4 compatibility RabbitMQ 4.1.0+ requires minimum frame_max of 8192, but amqplib <0.10.7 defaults to 4096, causing connection negotiation failures. This was causing CI tests to hang with continuous reconnection attempts until timeout. Updated peer dependency from "0.10" to ">=0.10.7" to ensure compatibility. Fixes connection errors: "negotiated frame_max = 4096 is lower than the minimum allowed value (8192)" Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…eply-to in RabbitMQ 4 RabbitMQ 4 doesn't allow acknowledgments on the special amq.rabbitmq.reply-to pseudo-queue. This was causing test failures with: "PRECONDITION_FAILED - reply consumer cannot acknowledge" When using the direct reply-to mechanism, we now force noAck=true regardless of the user's noAck configuration, since acks are not supported on this queue. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…to with noAck=false Add explicit warning when user configures amq.rabbitmq.reply-to with noAck=false, which is incompatible with RabbitMQ 4.x. This helps users understand the configuration issue before encountering runtime errors. The warning suggests either: - Setting noAck=true in options - Using a custom reply queue name instead Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileInterceptorto iterate through all multipart parts instead of only processing the first oneChanges
handleMultipartSingleFileto usefor awaitloop (matching the pattern inhandleMultipartMultipleFiles)Test Plan
Fixes
Closes #107
🤖 Generated with Claude Code