Skip to content

Conversation

delthas
Copy link
Contributor

@delthas delthas commented Oct 30, 2020

SetTitle is available on both MacOS and Linux.

  • Has existing documentation been updated?

Irrelevant:
- [ ] Do the tests pass? Consistently?
- [ ] Did this change improve test coverage?
- [ ] Has it been reviewed/approved by relevant teammates?
- [ ] Can it be QA’d in staging or something like staging?
- [ ] Is the code in question being linted? If not, consider adding a linter step to CI. If yes, make sure the linter is happy.
- [ ] Do we know how we’re going to deploy this?
- [ ] Are we clear on what the support and maintenance impact is?
- [ ] Did you create new documentation? Is it accessible and in the right place?
- [ ] Have you logged tickets for related technical debt with the label “techdebt”?

SetTitle is available on both MacOS and Linux.
@joesis joesis merged commit 58b3fe8 into getlantern:master Nov 2, 2020
ropog3ovomou pushed a commit to ropog3ovomou/systray that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants