-
Notifications
You must be signed in to change notification settings - Fork 0
Add unbounded broflake widget proxy lifecycle manager #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myleshorton
wants to merge
7
commits into
main
Choose a base branch
from
adam/unbounded-widget-proxy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6e6645b
Add unbounded broflake widget proxy lifecycle manager
myleshorton af7a0f0
Point to merged common on main, drop local replace
myleshorton cee8e17
Point to merged broflake on main, drop local replace
myleshorton 8232d78
Restore server-side checks in shouldRunUnbounded
myleshorton 21ef833
Address PR review: add doc comments, cancel cleanup, and tests
myleshorton 098367b
Address remaining PR comments: race condition docs, ignored return value
myleshorton 4804667
Fix TestSetUnboundedToggle failing in CI
myleshorton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version tag 'v0.51.3-unbounded' uses a non-standard format. Semantic versioning typically uses pre-release identifiers with a hyphen (e.g., v0.51.3-alpha.1), but 'unbounded' appears to be a fork identifier rather than a pre-release version. This is valid for Go modules, but consider using a more conventional approach like using a pseudo-version (v0.0.0-YYYYMMDDHHMMSS-commithash) or a proper pre-release tag to avoid confusion with actual semver pre-releases.