Skip to content

Comments

Auth fix v4#8486

Merged
atavism merged 3 commits intomainfrom
jigar/auth-fix-v4
Feb 19, 2026
Merged

Auth fix v4#8486
atavism merged 3 commits intomainfrom
jigar/auth-fix-v4

Conversation

@jigar-f
Copy link
Contributor

@jigar-f jigar-f commented Feb 19, 2026

This pull request introduces a new renewSubscription flow to the authentication process, updates the subscription and payment logic to handle user renewal scenarios, and adds a logout option for users who are logged in but do not have a Pro subscription. It also includes some minor code cleanups and UI adjustments.

Authentication and Subscription Flow Updates:

  • Added renewSubscription to the AuthFlow enum and integrated handling for this flow in the payment and email confirmation screens (app_eum.dart, choose_payment_method.dart, confirm_email.dart). [1] [2] [3] [4] [5]
  • Updated the plans logic to detect when a logged-in user is not Pro and route them to the renewal flow, and refactored the expired user handling to a new userRenewalFlow method (plans.dart).

Settings and Logout Enhancements:

  • Added a logout card and dialog for logged-in users without a Pro session, including confirmation and error handling (setting.dart). [1] [2]
  • Imported the required notifier for logout functionality (setting.dart).

Minor UI and Code Cleanups:

  • Removed the unused "more options" button from the payment method app bar and made minor formatting adjustments (choose_payment_method.dart). (F090da39L18R18)
  • Small code cleanups in payment flow logic (choose_payment_method.dart).
  • Added a missing import for home_notifier in plans (plans.dart).
  • Minor formatting fix in SVG widget (logs_path.dart).

@jigar-f jigar-f self-assigned this Feb 19, 2026
@jigar-f jigar-f marked this pull request as ready for review February 19, 2026 16:43
break;
case AuthFlow.renewSubscription:
// TODO: Handle this case.
throw UnimplementedError();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to implement these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, renewals do not need verification.

Copy link
Contributor

@myleshorton myleshorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks fine to me!

@atavism atavism merged commit c5b0283 into main Feb 19, 2026
9 checks passed
@atavism atavism deleted the jigar/auth-fix-v4 branch February 19, 2026 18:25
@atavism
Copy link
Contributor

atavism commented Feb 19, 2026

LGTM too!

atavism pushed a commit that referenced this pull request Feb 20, 2026
* Show logout when user is free when logged in

* paymnet fix

* added flow for renewal subscription.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants