Skip to content

Comments

System tray updates#8478

Merged
jigar-f merged 4 commits intomainfrom
jigar/system-tray-features
Feb 20, 2026
Merged

System tray updates#8478
jigar-f merged 4 commits intomainfrom
jigar/system-tray-features

Conversation

@jigar-f
Copy link
Contributor

@jigar-f jigar-f commented Feb 18, 2026

This pull request makes significant improvements to the system tray functionality, focusing on enhancing the VPN tray menu experience. The changes introduce dynamic updates based on user state, add new menu options, and refactor code for clarity and maintainability.

System Tray Menu Enhancements

  • Added a dynamic display of the current VPN location (with flag emoji and city/country) in the tray menu when connected.
  • Introduced a "Smart Location" option at the top of the location selection submenu, allowing users to quickly select automatic location, with a checkmark indicating the current selection.
  • Added a "Routing Mode" submenu to the tray, enabling users to toggle between "Smart Routing" and "Full Tunnel" modes directly from the tray, with checkboxes reflecting the current mode.

State Management and Reactivity

  • The tray menu now listens for changes in server location and routing mode, updating the UI in real time when these settings change. [1] [2]
  • Refactored logic for MacOS system extension checks into a reusable method, ensuring consistent behavior when starting VPN or changing locations. [1] [2]

Code Organization and Utility

  • Added a utility function to convert ISO country codes to flag emojis for improved location display.
  • Updated provider hash strings to reflect the new code state. [1] [2]

@jigar-f jigar-f self-assigned this Feb 18, 2026
@jigar-f jigar-f requested a review from Copilot February 18, 2026 11:34
@jigar-f jigar-f marked this pull request as ready for review February 18, 2026 11:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the desktop system tray VPN menu by making it reactive to routing-mode and server-location changes, and by adding new tray controls for “Smart Location” and routing mode selection.

Changes:

  • Add dynamic tray UI updates driven by serverLocationProvider and appSettingProvider (routing mode).
  • Add “Smart Location” and a “Routing Mode” submenu to the tray menu, plus connected-location display (flag + name).
  • Refactor macOS system extension gating into a reusable helper.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.

File Description
macos/Podfile.lock Updates CocoaPods checksums due to dependency/plugin changes.
lib/features/system_tray/provider/system_tray_notifier.dart Implements reactive tray updates, new menu items/submenus, and flag/location display logic.
lib/features/system_tray/provider/system_tray_notifier.g.dart Regenerates Riverpod provider hash after notifier changes.
lib/features/home/provider/home_notifier.g.dart Regenerates Riverpod provider hash after upstream changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jigar-f jigar-f merged commit 011c276 into main Feb 20, 2026
9 checks passed
@jigar-f jigar-f deleted the jigar/system-tray-features branch February 20, 2026 05:48
atavism added a commit that referenced this pull request Feb 20, 2026
* update tray menu with new features

* code review updates and use pubspec build number always.

* update comment

---------

Co-authored-by: atavism <atavism@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants