Skip to content

CI: gate nightly/release publishing on successful builds #8464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
atavism wants to merge 2 commits into from
Closed

CI: gate nightly/release publishing on successful builds #8464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd24eed
prevent nightly release publish when builds fail
atavism Feb 10, 2026
dc958c7
fix cleanup job
atavism Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 44 additions & 17 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,15 @@
build-android,
build-ios,
]
if: ${{ always() }}
# Only publish if all upstream jobs succeeded or were skipped
if: |
!cancelled() &&
needs.set-nightly-metadata.result == 'success' &&
(needs.build-macos.result == 'success' || needs.build-macos.result == 'skipped') &&
(needs.build-windows.result == 'success' || needs.build-windows.result == 'skipped') &&
(needs.build-linux.result == 'success' || needs.build-linux.result == 'skipped') &&
(needs.build-android.result == 'success' || needs.build-android.result == 'skipped') &&
(needs.build-ios.result == 'success' || needs.build-ios.result == 'skipped')
runs-on: ubuntu-latest
env:
INSTALLER_NAME: ${{ needs.set-nightly-metadata.outputs.installer_name }}
Expand Down Expand Up @@ -259,22 +267,6 @@
# Publish the draft release (only if artifact upload succeeded)
gh release edit "$VERSION" --draft=false

# Don't keep releases where artifact creation or upload has failed.
- name: Cleanup Failed GitHub Pre-Release
if: |
(failure() ||
needs.build-macos.result == 'failure' ||
needs.build-windows.result == 'failure' ||
needs.build-linux.result == 'failure' ||
needs.build-android.result == 'failure' ||
needs.build-ios.result == 'failure') &&
github.event.inputs.dry_run != 'true'
env:
GH_TOKEN: ${{ github.token }}
VERSION: ${{ needs.set-nightly-metadata.outputs.version }}
run: |
gh release delete "$VERSION" --cleanup-tag

- name: Upload to S3 (nightly + latest)
if: github.event.inputs.dry_run != 'true'
run: |
Expand Down Expand Up @@ -378,3 +370,38 @@
{
"text": "${{ steps.slack_msg.outputs.text }}"
}
# Don't keep releases where artifact creation or upload has failed.
cleanup:
needs:
[
set-nightly-metadata,
build-macos,
build-windows,
build-linux,
build-android,
build-ios,
publish,
]
if: |
always() &&
github.event.inputs.dry_run != 'true' &&
needs.set-nightly-metadata.result == 'success' &&
(
needs.build-macos.result == 'failure' || needs.build-macos.result == 'cancelled' ||
needs.build-windows.result == 'failure' || needs.build-windows.result == 'cancelled' ||
needs.build-linux.result == 'failure' || needs.build-linux.result == 'cancelled' ||
needs.build-android.result == 'failure' || needs.build-android.result == 'cancelled' ||
needs.build-ios.result == 'failure' || needs.build-ios.result == 'cancelled' ||
needs.publish.result == 'failure' || needs.publish.result == 'cancelled'
)
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Cleanup Failed GitHub Pre-Release
env:
GH_TOKEN: ${{ github.token }}
VERSION: ${{ needs.set-nightly-metadata.outputs.version }}
run: |
set -euxo pipefail
# Delete if it exists
gh release delete "$VERSION" --cleanup-tag || true
Comment on lines 375 to 407

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}

Copilot Autofix

AI 14 days ago

In general, the fix is to define an explicit permissions: block in the workflow, specifying the minimal scopes required. You can do this either at the workflow root (so it applies to all jobs) or per job. Since the CodeQL warning is about the workflow not limiting GITHUB_TOKEN, the most straightforward fix is to add a root‑level permissions: block with contents: read as a safe baseline, and then selectively elevate permissions for jobs that must modify releases or other resources.

For this specific file, the cleanup job uses gh release delete, which requires write access to repository contents. At minimum, that job needs contents: write. Other jobs like publish are likely also creating or updating releases or assets, but since their internals are not shown and the CodeQL report is specifically pointing at the workflow lacking any permissions: block, we can provide a minimal, non‑breaking fix by: (1) adding a workflow‑level permissions: contents: read immediately after the name: Nightly line, and (2) adding a job‑level permissions: block to the cleanup job specifying contents: write. This keeps the default for all jobs read‑only while granting write rights only where clearly needed, without altering the jobs’ logic.

Concretely:

  • Edit .github/workflows/nightly.yml.

  • After line 1 (name: Nightly), insert:

    permissions:
  contents: read

  • In the cleanup job definition (around lines 374–399), add:

        permissions:
      contents: write

    just before runs-on: ubuntu-latest. This ensures that only the cleanup job has write permissions needed for gh release delete, while other jobs run with read‑only contents permissions by default.

No additional imports or external dependencies are required; this is purely a YAML configuration change.

Suggested changeset 1
.github/workflows/nightly.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -1,4 +1,6 @@
 name: Nightly
+permissions:
+  contents: read
 
 on:
   schedule:
@@ -394,6 +396,8 @@
         needs.build-ios.result     == 'failure'   || needs.build-ios.result     == 'cancelled' ||
         needs.publish.result       == 'failure'   || needs.publish.result       == 'cancelled'
       )
+    permissions:
+      contents: write
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
EOF
@@ -1,4 +1,6 @@
name: Nightly
permissions:
contents: read

on:
schedule:
@@ -394,6 +396,8 @@
needs.build-ios.result == 'failure' || needs.build-ios.result == 'cancelled' ||
needs.publish.result == 'failure' || needs.publish.result == 'cancelled'
)
permissions:
contents: write
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Copilot is powered by AI and may make mistakes. Always verify output.
110 changes: 60 additions & 50 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,55 +140,16 @@ jobs:
build_type: ${{ needs.set-release-metadata.outputs.build_type }}
installer_name: ${{ needs.set-release-metadata.outputs.installer_name }}

upload-google-play:
needs: [set-release-metadata, build-android]
if:
${{ (needs.set-release-metadata.outputs.platform == 'all' || needs.set-release-metadata.outputs.platform == 'android')
&& (needs.set-release-metadata.outputs.build_type == 'beta' || needs.set-release-metadata.outputs.build_type == 'production') }}
runs-on: ubuntu-latest
steps:
- name: Download AAB artifact
uses: actions/download-artifact@v4
with:
name: lantern-installer-aab
path: aab

- name: Download mapping.txt
uses: actions/download-artifact@v4
with:
name: play-mapping
path: play

- name: Download native debug symbols
uses: actions/download-artifact@v4
with:
name: play-debug-symbols
path: play

- name: Pick Play track
id: track
run: |
if [ "${{ needs.set-release-metadata.outputs.build_type }}" = "beta" ]; then
echo "track=beta" >> "$GITHUB_OUTPUT"
else
echo "track=production" >> "$GITHUB_OUTPUT"
fi

- name: Upload to Google Play
uses: r0adkll/upload-google-play@v1
with:
serviceAccountJsonPlainText: ${{ secrets.SERVICE_ACCOUNT_JSON }}
packageName: org.getlantern.lantern
releaseFiles: aab/*.aab
track: ${{ steps.track.outputs.track }}
status: completed
mappingFile: play/mapping.txt
debugSymbols: play/debug-symbols.zip

publish:
needs:
[set-release-metadata, build-macos, build-linux, build-android, build-ios]
if: always()
if: |
!cancelled() &&
needs.set-release-metadata.result == 'success' &&
(needs.build-macos.result == 'success' || needs.build-macos.result == 'skipped') &&
(needs.build-linux.result == 'success' || needs.build-linux.result == 'skipped') &&
(needs.build-android.result == 'success' || needs.build-android.result == 'skipped') &&
(needs.build-ios.result == 'success' || needs.build-ios.result == 'skipped')
runs-on: ubuntu-latest
env:
BUILD_TYPE: ${{ needs.set-release-metadata.outputs.build_type }}
Expand Down Expand Up @@ -362,11 +323,60 @@ jobs:
env:
INSTALLER_NAME: ${{ needs.set-release-metadata.outputs.installer_name }}

upload-google-play:
needs: [set-release-metadata, build-android, publish]
if: |
!cancelled() &&
needs.publish.result == 'success' &&
(needs.set-release-metadata.outputs.platform == 'all' || needs.set-release-metadata.outputs.platform == 'android') &&
(needs.set-release-metadata.outputs.build_type == 'beta' || needs.set-release-metadata.outputs.build_type == 'production')
runs-on: ubuntu-latest
steps:
- name: Download AAB artifact
uses: actions/download-artifact@v4
with:
name: lantern-installer-aab
path: aab

- name: Download mapping.txt
uses: actions/download-artifact@v4
with:
name: play-mapping
path: play

- name: Download native debug symbols
uses: actions/download-artifact@v4
with:
name: play-debug-symbols
path: play

- name: Pick Play track
id: track
run: |
if [ "${{ needs.set-release-metadata.outputs.build_type }}" = "beta" ]; then
echo "track=beta" >> "$GITHUB_OUTPUT"
else
echo "track=production" >> "$GITHUB_OUTPUT"
fi

- name: Upload to Google Play
uses: r0adkll/upload-google-play@v1
with:
serviceAccountJsonPlainText: ${{ secrets.SERVICE_ACCOUNT_JSON }}
packageName: org.getlantern.lantern
releaseFiles: aab/*.aab
track: ${{ steps.track.outputs.track }}
status: completed
mappingFile: play/mapping.txt
debugSymbols: play/debug-symbols.zip

upload-testflight:
needs: [build-ios, set-release-metadata]
if:
${{ (needs.set-release-metadata.outputs.platform == 'all' || needs.set-release-metadata.outputs.platform == 'ios')
&& (needs.set-release-metadata.outputs.build_type == 'beta' || needs.set-release-metadata.outputs.build_type == 'production') }}
needs: [set-release-metadata, build-ios, publish]
if: |
!cancelled() &&
needs.publish.result == 'success' &&
(needs.set-release-metadata.outputs.platform == 'all' || needs.set-release-metadata.outputs.platform == 'ios') &&
(needs.set-release-metadata.outputs.build_type == 'beta' || needs.set-release-metadata.outputs.build_type == 'production')
runs-on: macos-14
steps:
- name: Download iOS Artifact
Expand Down
Loading