Skip to content

Comments

Fix tablet upscaling and cap shared component sizing#8457

Merged
jigar-f merged 9 commits intomainfrom
atavism/ipad-issues
Feb 16, 2026
Merged

Fix tablet upscaling and cap shared component sizing#8457
jigar-f merged 9 commits intomainfrom
atavism/ipad-issues

Conversation

@atavism
Copy link
Contributor

@atavism atavism commented Feb 9, 2026

Resolves https://github.com/getlantern/engineering/issues/2879

Uses device designSize on tablets to avoid ScreenUtil upscaling. Introduces capped scaling helpers and updates shared components (buttons/text field/logo)

Copy link
Contributor

@jigar-f jigar-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jigar-f jigar-f merged commit f1a2f79 into main Feb 16, 2026
9 checks passed
@jigar-f jigar-f deleted the atavism/ipad-issues branch February 16, 2026 09:53
atavism added a commit that referenced this pull request Feb 17, 2026
* Hide onboarding and datacap in ios  (#8466)

* Hide onboarding page and datacap in ios and update build number

* code review updates

* Garmr/ipc auth update (#8468)

* pull in radiance changes

* remove exclude arch in debug mode

* Update to latest radiance with no DNSTT since its breaking stuff (#8470)

* build and release updates (#8455)

* add safe area in plans

* Fix tablet upscaling and cap shared component sizing (#8457)

* update design size for tablets

* add cap scaling

* update mintextadapt

* logo updates and clean-ups

* update text fields

* clean-ups

* clean-ups

* fix scaling issue

---------

Co-authored-by: Jigar-f <jigar@getlantern.org>

* Fix for closing TUN (#8471)

* Fix stage env toggle and store gating

* Narrow followups to staging env

* Enable Play store uploads for internal Android releases (#8467)

* add support for internal Android releases

* use correct name for internal track

* update r0adkll/upload-google-play

* Fix track name

* update versionCode

* update foreground service permission

* disable exact alarm

---------

Co-authored-by: jigar-f <132374182+jigar-f@users.noreply.github.com>
Co-authored-by: garmr-ulfr <104022054+garmr-ulfr@users.noreply.github.com>
Co-authored-by: Jigar-f <jigar@getlantern.org>
Co-authored-by: Myles Horton <afisk@getlantern.org>
Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com>
jigar-f added a commit that referenced this pull request Feb 20, 2026
* work for stage env

* update var name

* use output var

* set output

* Update nightly.yml

* try to use as env variable

* Update build-macos.yml

* update name

* Remove stage for now & add default value

* keep default and pass value

* Simplify macos changes

* Remove stage again

* More debugging

* compare it as string

* added debug log

* update radiance.

* updated radiance

* update radiance

* use remote source

* more stage changes

* use radiance remote

* Add stage env connection.

* Revert workflows

* generate ffi

* use radiance remote and remove duplication logic

* ran make format

* use in app purchase for macos.

* back to storekit one.

* Switch to user on acknowledge purchase if found.

* use new radiance.

* update radiance.

* do not clear all data

* Harden stage environment toggle and env normalization (#8475)

* Hide onboarding and datacap in ios  (#8466)

* Hide onboarding page and datacap in ios and update build number

* code review updates

* Garmr/ipc auth update (#8468)

* pull in radiance changes

* remove exclude arch in debug mode

* Update to latest radiance with no DNSTT since its breaking stuff (#8470)

* build and release updates (#8455)

* add safe area in plans

* Fix tablet upscaling and cap shared component sizing (#8457)

* update design size for tablets

* add cap scaling

* update mintextadapt

* logo updates and clean-ups

* update text fields

* clean-ups

* clean-ups

* fix scaling issue

---------

Co-authored-by: Jigar-f <jigar@getlantern.org>

* Fix for closing TUN (#8471)

* Fix stage env toggle and store gating

* Narrow followups to staging env

* Enable Play store uploads for internal Android releases (#8467)

* add support for internal Android releases

* use correct name for internal track

* update r0adkll/upload-google-play

* Fix track name

* update versionCode

* update foreground service permission

* disable exact alarm

---------

Co-authored-by: jigar-f <132374182+jigar-f@users.noreply.github.com>
Co-authored-by: garmr-ulfr <104022054+garmr-ulfr@users.noreply.github.com>
Co-authored-by: Jigar-f <jigar@getlantern.org>
Co-authored-by: Myles Horton <afisk@getlantern.org>
Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com>

* Revert back some changes

* Fix issue with stage

* Fix stage issue on windows

* update logs

* revert back macos in app purchase changes

---------

Co-authored-by: atavism <atavism@users.noreply.github.com>
Co-authored-by: garmr-ulfr <104022054+garmr-ulfr@users.noreply.github.com>
Co-authored-by: Myles Horton <afisk@getlantern.org>
Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com>
Co-authored-by: atavism <paul@getlantern.org>
atavism added a commit that referenced this pull request Feb 20, 2026
* work for stage env

* update var name

* use output var

* set output

* Update nightly.yml

* try to use as env variable

* Update build-macos.yml

* update name

* Remove stage for now & add default value

* keep default and pass value

* Simplify macos changes

* Remove stage again

* More debugging

* compare it as string

* added debug log

* update radiance.

* updated radiance

* update radiance

* use remote source

* more stage changes

* use radiance remote

* Add stage env connection.

* Revert workflows

* generate ffi

* use radiance remote and remove duplication logic

* ran make format

* use in app purchase for macos.

* back to storekit one.

* Switch to user on acknowledge purchase if found.

* use new radiance.

* update radiance.

* do not clear all data

* Harden stage environment toggle and env normalization (#8475)

* Hide onboarding and datacap in ios  (#8466)

* Hide onboarding page and datacap in ios and update build number

* code review updates

* Garmr/ipc auth update (#8468)

* pull in radiance changes

* remove exclude arch in debug mode

* Update to latest radiance with no DNSTT since its breaking stuff (#8470)

* build and release updates (#8455)

* add safe area in plans

* Fix tablet upscaling and cap shared component sizing (#8457)

* update design size for tablets

* add cap scaling

* update mintextadapt

* logo updates and clean-ups

* update text fields

* clean-ups

* clean-ups

* fix scaling issue

---------

Co-authored-by: Jigar-f <jigar@getlantern.org>

* Fix for closing TUN (#8471)

* Fix stage env toggle and store gating

* Narrow followups to staging env

* Enable Play store uploads for internal Android releases (#8467)

* add support for internal Android releases

* use correct name for internal track

* update r0adkll/upload-google-play

* Fix track name

* update versionCode

* update foreground service permission

* disable exact alarm

---------

Co-authored-by: jigar-f <132374182+jigar-f@users.noreply.github.com>
Co-authored-by: garmr-ulfr <104022054+garmr-ulfr@users.noreply.github.com>
Co-authored-by: Jigar-f <jigar@getlantern.org>
Co-authored-by: Myles Horton <afisk@getlantern.org>
Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com>

* Revert back some changes

* Fix issue with stage

* Fix stage issue on windows

* update logs

* revert back macos in app purchase changes

---------

Co-authored-by: atavism <atavism@users.noreply.github.com>
Co-authored-by: garmr-ulfr <104022054+garmr-ulfr@users.noreply.github.com>
Co-authored-by: Myles Horton <afisk@getlantern.org>
Co-authored-by: Jay <110402935+jay-418@users.noreply.github.com>
Co-authored-by: atavism <paul@getlantern.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants