Skip to content

Comments

Fixes blank screen if the user chooses to Connect Now during onboarding#8453

Merged
jigar-f merged 1 commit intomainfrom
myles/connect-now-blank-screen
Feb 9, 2026
Merged

Fixes blank screen if the user chooses to Connect Now during onboarding#8453
jigar-f merged 1 commit intomainfrom
myles/connect-now-blank-screen

Conversation

@myleshorton
Copy link
Contributor

@myleshorton myleshorton commented Feb 6, 2026

See https://wdynhnkxvsdx.slack.com/archives/C04T8M4AB1Q/p1770411785853549

This pull request improves the user experience and stability of the onboarding and system extension dialogs, particularly on macOS. The main focus is on deferring navigation actions to the next frame to prevent calling navigation or state changes during widget builds, which can cause runtime errors or unexpected behavior.

Improvements to navigation and dialog handling:

  • Defers the closing of the system extension dialog until the next frame after detecting the extension is installed and activated, preventing navigation during the build process (macos_extension_dialog.dart).
  • Defers the presentation of the macOS extension dialog until the next frame after onboarding is completed, ensuring navigation actions are not performed during build (onboarding.dart).
  • Removes redundant appRouter.pop() call before calling onboardingCompleted() to streamline the onboarding completion logic (onboarding.dart).

Stability improvements in effect hooks:

  • Wraps routing mode logic in a microtask using Future(() { ... }) to ensure it runs after the current build, avoiding side effects during widget construction (onboarding.dart). [1] [2]

@myleshorton myleshorton requested a review from jigar-f February 6, 2026 22:25
Copy link
Contributor

@jigar-f jigar-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

@jigar-f jigar-f merged commit 5a1d811 into main Feb 9, 2026
9 checks passed
@jigar-f jigar-f deleted the myles/connect-now-blank-screen branch February 9, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants