Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building development lantern on Windows #4075

Merged
merged 9 commits into from
May 6, 2016
Merged

Support building development lantern on Windows #4075

merged 9 commits into from
May 6, 2016

Conversation

oxtoacart
Copy link
Contributor

The packaging stuff won't work yet, but at least I can build the lantern target and run Lantern.

bin/tarfs -pkg ui $$DIST >> $$DEST

# Generates a syso file that embeds an icon for the Windows executable
generate-windows-icon:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syso is now back in git so I don't need to run this on Windows, which is good because it doesn't run.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 69.383% when pulling 1be8a6e on windowsbuild into 8fdaae0 on devel.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 69.7% when pulling 237b1a8 on windowsbuild into 8fdaae0 on devel.

@xiam xiam self-assigned this May 2, 2016
@xiam
Copy link
Contributor

xiam commented May 2, 2016

Gonna take this one, looks like we have a conflict @oxtoacart, could you rebase and push again?

@oxtoacart
Copy link
Contributor Author

@xiam Merged

@oxtoacart
Copy link
Contributor Author

@xiam I mean, I reverse merged to resolve the conflict :)

@xiam
Copy link
Contributor

xiam commented May 5, 2016

Hey @oxtoacart, looks good, just made a few changes. What are the name changes required for? I mean, moving ui to the root.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 71.061% when pulling bb08d39 on windowsbuild into bbbf811 on devel.

@oxtoacart
Copy link
Contributor Author

@xiam By "name changes" do you mean all the moved files in lantern-ui? With lantern-ui in the original location, the directory structure is too deep for Windows which has a maximum path length of 260.

@xiam
Copy link
Contributor

xiam commented May 6, 2016

Yeah, that's it. Hmm, not sure if that justifies changing the path for the
whole project. Isn't it possible to use soft links or equivalent? I'll take
a look too trying to find another solution.
On Thu, May 5, 2016 at 20:03 oxtoacart notifications@github.com wrote:

@xiam https://github.com/xiam By "name changes" do you mean all the
moved files in lantern-ui? With lantern-ui in the original location, the
directory structure is too deep for Windows which has a maximum path length
of 260.


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#4075 (comment)

@oxtoacart
Copy link
Contributor Author

@xiam I only moved lantern-ui. It's actually kind of strange to have it in the GOPATH in the first place, and I used git mv to move it, so it shouldn't cause any merge issues.

@myleshorton
Copy link
Contributor

Yeah I agree @oxtoacart it's a little weird to have lantern-ui in the GOPATH.

@xiam
Copy link
Contributor

xiam commented May 6, 2016

Ok then @myleshorton & @oxtoacart, I think that having our source code on src makes more sense, but if you both agree let's leave it like that. Otherwise the build works for me.

@xiam xiam merged commit 4020b42 into devel May 6, 2016
@xiam xiam deleted the windowsbuild branch May 6, 2016 12:33
@oxtoacart
Copy link
Contributor Author

@xiam thanks for the review and improving the Makefile!

@myleshorton
Copy link
Contributor

Nice @xiam!!

oxtoacart pushed a commit that referenced this pull request Apr 28, 2020
Support building development lantern on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants