-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building development lantern on Windows #4075
Conversation
bin/tarfs -pkg ui $$DIST >> $$DEST | ||
|
||
# Generates a syso file that embeds an icon for the Windows executable | ||
generate-windows-icon: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The syso is now back in git so I don't need to run this on Windows, which is good because it doesn't run.
Gonna take this one, looks like we have a conflict @oxtoacart, could you rebase and push again? |
@xiam Merged |
@xiam I mean, I reverse merged to resolve the conflict :) |
Few fixes for building on Windows.
Hey @oxtoacart, looks good, just made a few changes. What are the name changes required for? I mean, moving ui to the root. |
@xiam By "name changes" do you mean all the moved files in lantern-ui? With lantern-ui in the original location, the directory structure is too deep for Windows which has a maximum path length of 260. |
Yeah, that's it. Hmm, not sure if that justifies changing the path for the
|
@xiam I only moved lantern-ui. It's actually kind of strange to have it in the GOPATH in the first place, and I used git mv to move it, so it shouldn't cause any merge issues. |
Yeah I agree @oxtoacart it's a little weird to have lantern-ui in the GOPATH. |
Ok then @myleshorton & @oxtoacart, I think that having our source code on |
@xiam thanks for the review and improving the Makefile! |
Nice @xiam!! |
Support building development lantern on Windows
The packaging stuff won't work yet, but at least I can build the
lantern
target and run Lantern.