README and Makefile cleanups #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e release docs into a separate folder, etc.
| echo docker run `echo $(DOCKER_VOLS) | xargs` -t $(DOCKER_IMAGE_TAG) /bin/bash -c 'cd /lantern && VERSION="'$$VERSION'" HEADLESS="'$$HEADLESS'" BNS_CERT_PASS="'$$BNS_CERT_PASS'" make $*' && \ | ||
| docker run `echo $(DOCKER_VOLS) | xargs` -t $(DOCKER_IMAGE_TAG) /bin/bash -c 'cd /lantern && VERSION="'$$VERSION'" HEADLESS="'$$HEADLESS'" BNS_CERT_PASS="'$$BNS_CERT_PASS'" make $*'; | ||
|
|
||
| docker-test: system-checks |
There was a problem hiding this comment.
@myleshorton Why does this target need to duplicate the code on lines 173 to 180?
There was a problem hiding this comment.
Oh sorry -- committed docker-test by mistake. Will fix!
…n checkout regardless and fixed make lantern example
|
Hey how's this look now @oxtoacart? |
|
LGTM. I made one small addition about using clean-desktop - e6b20a5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks out the release details from the README @xiam and @oxtoacart since that only applies to Lantern developers actually creating releases and goes into detail that's unusual for a Makefile. I also added simple instructions for building "the old fashioned way" with just
go build. Finally, I added back themake dockertarget in the Makefile.