Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed black space at top of screen on Android 5.x closes #3592 #3621

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Removed black space at top of screen on Android 5.x closes #3592 #3621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/github.com/getlantern/lantern-mobile/app/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<resources>

<!-- Base application theme. -->
<style name="AppTheme" parent="Theme.AppCompat.Light.DarkActionBar">
<style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the actual fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It looks like AppTheme is the default theme whenever our main activity extends AppCompatActivity but only with 5.x -- anyway, just verified the black status bar is gone now! Merging.

<!-- Customize your theme here. -->
<item name="colorPrimary">@android:color/black</item>
<item name="elevation">0dp</item>
Expand All @@ -15,11 +15,6 @@
<item name="color">#39C2D6</item>
</style>

<style name="Theme.HomeScreen" parent="android:Theme.Holo.NoActionBar.TranslucentDecor">
<item name="android:windowBackground">@android:color/transparent</item>
<item name="android:windowNoTitle">true</item>
</style>

<style name="BackgroundImageView">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't necessary for the fix, but appeared to be dead code so I removed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yeah, this isn't being used anymore.

<item name="android:scaleType">fitCenter</item>
<item name="android:background">@drawable/desktop_graphic</item>
Expand Down