No longer continually vetting masquerades #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| func (d *direct) vetSome() { | ||
| func (d *direct) vetOne() { |
There was a problem hiding this comment.
This goroutine now terminates once it has successfully verified one masquerade. So, when we reconfigure, we don't end up piling up a bunch of goroutines. Also, we don't do a bunch of work vetting masquerades that we may never use.
fffw
added a commit
that referenced
this pull request
Feb 17, 2016
No longer continually vetting masquerades
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry the diff on util_test is so big, I just added all the masquerades because it was failing with its initial masquerades. Eventually, we should just have one place where we keep the list of masquerades (see #3587).