Valencia service #3585
Valencia service #3585
Conversation
| * classloader (i.e. to avoid loading native dependencies when running as service). This is | ||
| * important because in some situations, it appears that including the Lantern native library | ||
| * inside the same process as an application can cause instability on some phones (e.g. Samsung | ||
| * Galaxy S4). |
There was a problem hiding this comment.
This comment is important - it turns out that simply loading the native library into the Manoto app introduced instability. I structured Lantern so that simply importing it does not cause the native library to get loaded. That now happens only when the proxy is started, which when running as a service happens in a separate process.
|
@atavism @myleshorton What do you think? Merge worthy? |
|
I'm still knocking this around a little bit @oxtoacart |
| // Track extra info about Android for logging to Loggly. | ||
| EmbeddedLantern.addLoggingMetadata("androidDevice", android.os.Build.DEVICE); | ||
| org.lantern.mobilesdk.Lantern.addLoggingMetadata("androidModel", android.os.Build.MODEL); | ||
| org.lantern.mobilesdk.Lantern.addLoggingMetadata("androidSdkVersion", "" + android.os.Build.VERSION.SDK_INT + " (" + android.os.Build.VERSION.RELEASE + ")"); |
There was a problem hiding this comment.
Do we not want to log to Loggly in the service case @oxtoacart? I can definitely see not doing it, but want to make sure that's intentional.
There was a problem hiding this comment.
I think it makes sense to log to Loggly so that we get feedback on any issues that might be encountered by users of the embedded version.
There was a problem hiding this comment.
Yeah I'm guess I'm asking the opposite: do we also want to log to Loggly for the service version?
There was a problem hiding this comment.
Oh, now I understand your question. The service uses EmbeddedLantern, so they both already log to Loggly.
There was a problem hiding this comment.
Oh I see - I missed that! Cool thanks @oxtoacart.
|
All good on this PR from my end @atavism and @oxtoacart. |
|
Same here. Let's go head and merge this! Thanks, @oxtoacart! |
|
@atavism @myleshorton Thanks for the review! I've opened #3633 for the WebView thing. |
@myleshorton @atavism
This adds support for running the embedded Lantern as a service via
Lantern.enableAsService(). The testbed app is updated to support testing both regular embedded as well as service-mode embedded.