[important] Workaround for issue #3077 #3091
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3077 is confirmed to be triggered by panicwrap trying to fork a GUI app. This seems to offend Windows XP, due to invalid standard file descriptors. Unfortunately we didn't see any log of this because panicwrap fails before logging is configured. Additionally, this bug isn't detected because it doesn't happen if the application is run in console mode (which is generally used for development).
A better solution could be researched further, although I'm not certain it is viable yet, but I wanted to get this ASAP in valencia, since it could potentially affect all Windows XP users.