Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[important] Workaround for issue #3077 #3091

Merged
merged 1 commit into from
Sep 4, 2015
Merged

[important] Workaround for issue #3077 #3091

merged 1 commit into from
Sep 4, 2015

Conversation

uaalto
Copy link
Contributor

@uaalto uaalto commented Sep 3, 2015

Issue #3077 is confirmed to be triggered by panicwrap trying to fork a GUI app. This seems to offend Windows XP, due to invalid standard file descriptors. Unfortunately we didn't see any log of this because panicwrap fails before logging is configured. Additionally, this bug isn't detected because it doesn't happen if the application is run in console mode (which is generally used for development).

A better solution could be researched further, although I'm not certain it is viable yet, but I wanted to get this ASAP in valencia, since it could potentially affect all Windows XP users.

@uaalto
Copy link
Contributor Author

uaalto commented Sep 3, 2015

Yes, and this issue is also critical, it produces random segfaults.

@myleshorton
Copy link
Contributor

Yeah I think we should probably get this in, but keep in mind XP is only around 5% of our users (at least of the visitors to our web site) so not as urgent as it might otherwise be. I think the general connectivity issue is much more pressing right now.

@uaalto
Copy link
Contributor Author

uaalto commented Sep 3, 2015

Oh, I thought the number of XP users was higher! This OS version gives a lot headaches, the firewall thing was an example too.

@myleshorton
Copy link
Contributor

Hey I think we might as well put this in 2.0.2. Would you mind doing a PR to the release-2.0.1 branch @uaalto?

@uaalto
Copy link
Contributor Author

uaalto commented Sep 4, 2015

Done. I'm very happy I could finally use cherry-pick for a perfect case like this :)
I think we still have to merge this one, right? If it is a specific release branch, even if they are the same commit it needs to be merged back in valencia.

@myleshorton
Copy link
Contributor

Yeah either way @uaalto. The release branch will be merged back into valencia will a bunch of things again.

myleshorton added a commit that referenced this pull request Sep 4, 2015
[important] Workaround for issue #3077
@myleshorton myleshorton merged commit ce6b7a2 into valencia Sep 4, 2015
@myleshorton myleshorton deleted the issue-3077 branch September 4, 2015 18:33
@getlantern getlantern deleted a comment from fffw Mar 3, 2021
@getlantern getlantern deleted a comment from fffw Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants