Register and report User-Agents used in Lantern session #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "sync" | ||
| ) | ||
|
|
||
| type agentsMap map[string]int |
There was a problem hiding this comment.
Is this typedef really useful? Looks like it's just used in one place.
There was a problem hiding this comment.
I tend to use typedefs for long-ish definitions to clarify what they actually mean. In this case I agree it doesn't help much.
|
A couple nits but otherwise LGTM! |
|
LGTM! |
myleshorton
added a commit
that referenced
this pull request
Aug 18, 2015
Register and report User-Agents used in Lantern session
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2925