fix(invoice): Change Regenerate invoice components to retrieve preview invoice#3564
Open
tiagolupepic wants to merge 19 commits into
Open
fix(invoice): Change Regenerate invoice components to retrieve preview invoice#3564tiagolupepic wants to merge 19 commits into
tiagolupepic wants to merge 19 commits into
Conversation
- Remove second call to invoices to get the fees
…ceBuildRegenerationPreviewQuery
AllanMichay
reviewed
May 29, 2026
tiagolupepic
force-pushed
the
feat/change-invoice-regenerate-to-use-draft-query
branch
from
e38e508 to
f15ef31
Compare
tiagolupepic
force-pushed
the
feat/change-invoice-regenerate-to-use-draft-query
branch
from
baac04e to
9e99d33
Compare
tiagolupepic
force-pushed
the
feat/change-invoice-regenerate-to-use-draft-query
branch
from
9e99d33 to
8002311
Compare
|
AllanMichay
approved these changes
Jun 3, 2026
tiagolupepic
force-pushed
the
feat/change-invoice-regenerate-to-use-draft-query
branch
6 times, most recently
from
6d387dc to
04a7948
Compare
tiagolupepic
force-pushed
the
feat/change-invoice-regenerate-to-use-draft-query
branch
3 times, most recently
from
0a39f4d to
fc68dbc
Compare
avoid conflicts with cached fee fragments And also improve the cache policy
tiagolupepic
force-pushed
the
feat/change-invoice-regenerate-to-use-draft-query
branch
from
fc68dbc to
c3e7211
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the CustomerInvoiceRegenerate and CreateInvoice to use a draft invoice query.
Recently, we detected a issue with a customer.
However, we have a scenario when customer changes their taxes and they want to regenerate invoices.
During the process to display the invoice information, frontend ask the invoice details using the invoice GraphQL query and as expected, we're still showing the applied taxes based on previous customer information.
We have a getlago/lago-api#5237 and introducing the GraphQL query and,
in this PR we're changing the CustomerInvoiceRegenerate and CreateInvoice to use the "preview" state.
Also, we're removing the extra query of fees because the fees are nested in the invoice draft query
and we don't need an extra query.
Dependency: getlago/lago-api#5237