Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: improve multiple combobox behaviour #1945

Merged
merged 1 commit into from
Dec 27, 2024
Merged

misc: improve multiple combobox behaviour #1945

merged 1 commit into from
Dec 27, 2024

Conversation

ansmonjol
Copy link
Collaborator

This PR fixes 2 aspects of the Multiple combobox

  • Make sure that once selected, we display the item label first THEN the value, in the input's badge
  • Fix the uncontrolled state warning, as it was initialised with undefined. Defaulting to empty string fixes this

@ansmonjol ansmonjol self-assigned this Dec 27, 2024
@ansmonjol ansmonjol enabled auto-merge (squash) December 27, 2024 09:21
@ansmonjol ansmonjol merged commit 812a9cc into main Dec 27, 2024
12 checks passed
@ansmonjol ansmonjol deleted the multiple-combobox branch December 27, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keellyp keellyp keellyp approved these changes

@stephenlago99 stephenlago99 Awaiting requested review from stephenlago99

Assignees

@ansmonjol ansmonjol

Labels
🌈 improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ansmonjol @keellyp