Remove LAGO_ prefix from encryption env vars
#210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2024
|
Hey @atwalsh tank you very much for pointing this mismatch between the code and the documentation. I have opened two pull requests to fix this. |
|
@vincent-pochet sounds good! Will close this for now. |
vincent-pochet
added a commit
to getlago/lago-api
that referenced
this pull request
Sep 24, 2024
## Context This PR is related to getlago/lago-doc#210 A mismatch was reported by a user between the environment variable defined on https://doc.getlago.com/guide/self-hosted/docker and the one used in the API application. ## Description This PR makes sure that the API application is using the environment variables defined in the documentation without breaking the setup for users using the docker-compose.yml file from the main Lago repository
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
LAGO_prefix from active record encryption env vars.I had to remove this prefix to get Docker deploy working for the API.
https://github.com/getlago/lago-api/blob/0be7efbea6bb41b8d80990dc6d7f4fe82cc345a2/config/application.rb#L30-L32