Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #277 Support weekly billing interval #283

Merged
merged 10 commits into from
Jun 24, 2022
Merged

Conversation

lovrocolic
Copy link
Collaborator

No description provided.

@lovrocolic lovrocolic self-assigned this Jun 22, 2022
@lovrocolic lovrocolic linked an issue Jun 22, 2022 that may be closed by this pull request
Copy link
Contributor

@jdenquin jdenquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me, let's QA it (a lot)!

spec/services/billing_service_spec.rb Show resolved Hide resolved
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, but looks good! 🚀

I guess, it's QA time now!!

app/services/billing_service.rb Outdated Show resolved Hide resolved
app/services/fees/subscription_service.rb Show resolved Hide resolved
@lovrocolic lovrocolic merged commit 0aeb212 into main Jun 24, 2022
@lovrocolic lovrocolic deleted the 277-weekly-billing branch June 24, 2022 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: Add weekly billing frequency
3 participants