fix(gocardless): Treat Gocardless webhooks events in separate jobs #2695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the GoCardless webhook events management and refactoring the integration by introducing new services for handling webhooks and events using the standard call/Result pattern.
The main changes include replacing direct calls to
GocardlessService
with more specific services and updating the logic to treat each webhook events in isolation to avoid failling a batch if a single event is causing an error.Refactoring and Service Extraction:
Refactored Webhook Handling:
GocardlessService.handle_incoming_webhook
withGocardless::HandleIncomingWebhookService.call
inWebhooksController
. (app/controllers/webhooks_controller.rb
)HandleIncomingWebhookService
. (app/services/payment_providers/gocardless/handle_incoming_webhook_service.rb
)Refactored Event Handling:
GocardlessService.handle_event
withGocardless::HandleEventService.call
inHandleEventJob
. (app/jobs/payment_providers/gocardless/handle_event_job.rb
)HandleEventService
. (app/services/payment_providers/gocardless/handle_event_service.rb
)events_json
input argument inHandleEventJob
to avoid issues with enqueued/dead jobs for now