Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable configuration for webhook attempts #265

Conversation

prognostikos
Copy link
Contributor

This change introduces the LAGO_WEBHOOK_ATTEMPTS environment variable,
which will be used instead of the default of 3 when attempting to
deliver webhooks.

This change introduces the `LAGO_WEBHOOK_ATTEMPTS` environment variable,
which will be used instead of the default of 3 when attempting to
deliver webhooks.
@prognostikos
Copy link
Contributor Author

I will see if I can fix the specs, on first glance the failures don't seem to be related to this change

@vincent-pochet vincent-pochet linked an issue Jun 17, 2022 that may be closed by this pull request
@vincent-pochet
Copy link
Collaborator

vincent-pochet commented Jun 17, 2022

Hey @prognostikos,

Thank you very much for this pull request!

It looks good to me.
For the failing specs, it seems related to the active record encryption that has been introduced later this week. I will have to dig a bit into it to understand what's going on.

@vincent-pochet vincent-pochet added enhancement New feature or request 🔔 Webhook Related to Webhooks Worker Related to worker labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔔 Webhook Related to Webhooks enhancement New feature or request Worker Related to worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT]: make webhook attempts configurable
2 participants