misc: Refact some services to the call pattern #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-pochet
force-pushed
the
misc-more-call
branch
from
f5a839e
to
1e54643
Compare
lovrocolic
reviewed
Sep 30, 2024
lovrocolic
approved these changes
Sep 30, 2024
vincent-pochet
added a commit
that referenced
this pull request
Oct 1, 2024
## Context This PR follows #2641 and keeps refactoring some old service to take advantage of the `call` pattern and to remove the `user` arguments used in `BaseService#initialize`. ## Description This PR: - Extract the `Customers::UpdateService#update_currency` method into a dedicated `Customers::UpdateCurrencyService` and adds specs - Turn the `Customers::UpdateService#update` method into a proper `Customers::UpdateService#call` one
vincent-pochet
added a commit
that referenced
this pull request
Oct 3, 2024
## Context This PR follows #2641 and #2645 and keeps refactoring some old service to take advantage of the `call` pattern and to remove the `user` arguments used in `BaseService#initialize`. ## Description This PR: - Turn the `Plans::CreateService#create` method into a proper `Plans::CreateService#call` one - Remove the need for the `current_user` argument in `Invites::CreateService` and move the arguments for the `call` method to the `initializer` - Refact `Invites::RevokeService` to take the `invite` as an argument instead if the `id` and `current_organization` and move the argument for the `call` method to the `initializer` - Remove the `current_user` argument for the `Invoices::CustomerUsageService`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some services inherinting from the
BaseServiceare not using theSERVCE_CLASS.callpattern. They are mostly old services that were created before the introduction of the pattern in the project.Description
To increase consistency in the code base, this PR turns some old services to the pattern.
The impacted services are:
AddOns::CreateServiceBillableMetrics::CreateServiceCoupons::CreateServiceAddOns::CreateServiceMore refactor will follow as other services have still to be converted.