-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dunning): Fix webhooks events processing and payment request email triggering on PSPs payment attempts #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsempe
approved these changes
Sep 9, 2024
ancorcruz
force-pushed
the
feat/dunning-qa-returns-email-trigger
branch
from
September 10, 2024 12:11
6fea8e8
to
b818f79
Compare
rsempe
approved these changes
Sep 10, 2024
ancorcruz
changed the title
Feat/dunning qa returns email trigger
feat(dunning): Fix webhooks events processing and payment request email triggering on PSPs payment attempts
Sep 11, 2024
on event reception... Where should the email be triggered on the service or the caller (event processor)?
when the payment status is payment failed
rsempe
force-pushed
the
feat/dunning-qa-returns-email-trigger
branch
from
September 12, 2024 08:54
874b223
to
e966ba8
Compare
on Adyen non successful response for the first payment intent, then the payment request requested email is sent to customer
ancorcruz
force-pushed
the
feat/dunning-qa-returns-email-trigger
branch
from
September 12, 2024 13:44
f90e423
to
f3e1bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap Task
👉 https://getlago.canny.io/feature-requests/p/send-reminders-for-overdue-invoices
Context
We want to be able to manually request payment of the overdue balance and send emails for reminders.
Description
The goal of this change is trigger PaymentRequest requested email when payable payment status is failed on PSPs payment attempts. The change includes all PSPs (stripe, adyen and gocardless) and payment creation and status update event scenarios.
Also, fixes a deprecation warning on payment request aliased attribute
total_amount_cents
and CTA translation on Payment Request requested email for German language.