Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #251 send webhook notification if event creation failed #252

Merged
merged 4 commits into from
Jun 14, 2022
Merged

feat: #251 send webhook notification if event creation failed #252

merged 4 commits into from
Jun 14, 2022

Conversation

lovrocolic
Copy link
Collaborator

No description provided.

vincent-pochet
vincent-pochet reviewed Jun 10, 2022
View reviewed changes
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've just made a suggestion regarding the organization optional parameter

app/services/events_service.rb Outdated Show resolved Hide resolved
app/services/events_service.rb Outdated Show resolved Hide resolved
vincent-pochet
vincent-pochet approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@vincent-pochet vincent-pochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment. Great job! 🚀

app/services/webhooks/event_service.rb Outdated Show resolved Hide resolved
jdenquin
jdenquin approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@jdenquin jdenquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good for me, nice one!

@lovrocolic lovrocolic merged commit fba3cac into main Jun 14, 2022
@lovrocolic lovrocolic deleted the 251-feat-error-event-webhook branch June 14, 2022 06:15
@vincent-pochet vincent-pochet mentioned this pull request Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdenquin jdenquin jdenquin approved these changes

@vincent-pochet vincent-pochet vincent-pochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lovrocolic @vincent-pochet @jdenquin