feat(hubspot): Remove obsolete private app token from Hubspot

app/graphql/types/integrations/hubspot.rb

@@ -10,7 +10,6 @@ class Hubspot < Types::BaseObject
       field :default_targeted_object, Types::Integrations::Hubspot::TargetedObjectsEnum, null: false
       field :id, ID, null: false
       field :name, String, null: false
-      field :private_app_token, String, null: false
       field :sync_invoices, Boolean
       field :sync_subscriptions, Boolean
     end

app/graphql/types/integrations/hubspot/create_input.rb

@@ -11,7 +11,6 @@ class CreateInput < Types::BaseInputObject
 
         argument :connection_id, String, required: true
         argument :default_targeted_object, Types::Integrations::Hubspot::TargetedObjectsEnum, required: true
-        argument :private_app_token, String, required: true
         argument :sync_invoices, Boolean, required: false
         argument :sync_subscriptions, Boolean, required: false
       end

app/graphql/types/integrations/hubspot/update_input.rb

@@ -13,7 +13,6 @@ class UpdateInput < Types::BaseInputObject
 
         argument :connection_id, String, required: false
         argument :default_targeted_object, Types::Integrations::Hubspot::TargetedObjectsEnum, required: false
-        argument :private_app_token, String, required: false
         argument :sync_invoices, Boolean, required: false
         argument :sync_subscriptions, Boolean, required: false
       end

app/models/integrations/hubspot_integration.rb

@@ -2,12 +2,12 @@
 
 module Integrations
   class HubspotIntegration < BaseIntegration
-    validates :connection_id, :private_app_token, :default_targeted_object, presence: true
+    validates :connection_id, :default_targeted_object, presence: true
 
     settings_accessors :default_targeted_object, :sync_subscriptions, :sync_invoices, :subscriptions_object_type_id,
       :invoices_object_type_id, :companies_properties_version, :contacts_properties_version,
       :subscriptions_properties_version, :invoices_properties_version, :portal_id
-    secrets_accessors :connection_id, :private_app_token
+    secrets_accessors :connection_id
 
     TARGETED_OBJECTS = %w[companies contacts].freeze
 

app/services/integrations/aggregator/custom_object_service.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+module Integrations
+  module Aggregator
+    class CustomObjectService < BaseService
+      def initialize(integration:, name:)
+        @name = name
+        super(integration:)
+      end
+
+      def action_path
+        "v1/#{provider}/custom-object"
+      end
+
+      def call
+        response = http_client.get(headers:, params:)
+
+        result.custom_object = OpenStruct.new(response)
+        result
+      end
+
+      private
+
+      attr_reader :name
+
+      def headers
+        {
+          'Connection-Id' => integration.connection_id,
+          'Authorization' => "Bearer #{secret_key}",
+          'Provider-Config-Key' => provider_key
+        }
+      end
+
+      def params
+        {
+          'name' => name
+        }
+      end
+    end
+  end
+end

app/services/integrations/hubspot/create_service.rb

@@ -22,7 +22,6 @@ def call
           name: params[:name],
           code: params[:code],
           connection_id: params[:connection_id],
-          private_app_token: params[:private_app_token],
           default_targeted_object: params[:default_targeted_object],
           sync_invoices: ActiveModel::Type::Boolean.new.cast(params[:sync_invoices]),
           sync_subscriptions: ActiveModel::Type::Boolean.new.cast(params[:sync_subscriptions])
@@ -31,7 +30,6 @@ def call
         integration.save!
 
         if integration.type == 'Integrations::HubspotIntegration'
-          Integrations::Aggregator::SendPrivateAppTokenJob.perform_later(integration:)
           Integrations::Aggregator::SyncCustomObjectsAndPropertiesJob.perform_later(integration:)
           Integrations::Hubspot::SavePortalIdJob.perform_later(integration:)
         end

app/services/integrations/hubspot/update_service.rb

@@ -17,21 +17,14 @@ def call
           return result.not_allowed_failure!(code: 'premium_integration_missing')
         end
 
-        old_private_app_token = integration.private_app_token
-
         integration.name = params[:name] if params.key?(:name)
         integration.code = params[:code] if params.key?(:code)
-        integration.private_app_token = params[:private_app_token] if params.key?(:private_app_token)
         integration.default_targeted_object = params[:default_targeted_object] if params.key?(:default_targeted_object)
         integration.sync_invoices = params[:sync_invoices] if params.key?(:sync_invoices)
         integration.sync_subscriptions = params[:sync_subscriptions] if params.key?(:sync_subscriptions)
 
         integration.save!
 
-        if integration.type == 'Integrations::HubspotIntegration' && integration.private_app_token != old_private_app_token
-          Integrations::Aggregator::SendPrivateAppTokenJob.perform_later(integration:)
-        end
-
         result.integration = integration
         result
       rescue ActiveRecord::RecordInvalid => e

spec/factories/integrations.rb

@@ -74,7 +74,7 @@
     end
 
     secrets do
-      {connection_id: SecureRandom.uuid, private_app_token: SecureRandom.uuid}.to_json
+      {connection_id: SecureRandom.uuid}.to_json
     end
   end
 end