Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Unknown alias: default (Psych::BadAlias) #93

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

ps-ruby
Copy link
Contributor

@ps-ruby ps-ruby commented Mar 6, 2022

Ruby 3.0 comes with Psych 3, while Ruby 3.1 comes with Psych 4, which has a major breaking change.

  1. The new YAML loading methods (Psych 4) do not load aliases unless they get the aliases: true argument.
  2. The old YAML loading methods (Psych 3) do not support the aliases keyword.

This change is breaking the codebase while loading the database.yml and this PR handles that for ruby 3.1.x

Copy link
Member

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ps-ruby :)

lib/kuby/plugins/rails_app/database.rb Show resolved Hide resolved
@ps-ruby
Copy link
Contributor Author

ps-ruby commented Mar 8, 2022

@camertron Sorbet check is failing for lib/kuby/docker/remote_tags.rb. I tried auto-correct and it is making the changes shown below.

image

Should I make push the above changes?

@camertron
Copy link
Member

@ps-ruby ah sorry about that. For some reason Sorbet isn't picking up that new class I added to Docker::Remote. I fixed it manually in master, so if you merge/rebase the tests should pass :)

@camertron camertron merged commit 9885015 into getkuby:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants