Add support to configure the number of web workers for puma #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for this @zhalltyemill 😄 Could you have a look at the Sorbet failures? Otherwise I think this looks good 👍 |
|
Yep sorry about that. I'll get those fixed up still getting the hang of sorbet. |
|
Integration tests are passing in master, so I have published v0.19.0 🎉 |
|
awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue my team was having with resource consumption for non production environments, with two replicas and 4 workers per replica an app that operates at 500MB of memory usage consumes 4GB. I've added an option to specify the number of workers that puma spawns so users have more granular control over their webservers and their resource consumption. I've left the default number of workers at 4 to prevent any breaking changes to user's configs.