test: Add unit tests for commands #116
Conversation
|
|
||
| public function testDescription(): void | ||
| { | ||
| $this->assertSame('Upgrades the Kirby core', Upgrade::description()); |
There was a problem hiding this comment.
I am wondering if we are doing ourselves a favor to check the exact strings here and also for argument descriptions. That means we always have to adapt tests just if that string changes. I think it could be fine to just assert for is string or so - that a description is set, not necessarily the exact words.
There was a problem hiding this comment.
TBH I think we hardly ever change the description and it would have helped to have this before moving everything to commands.
There was a problem hiding this comment.
But also there, it would have helped us just as much to assert if it still returns a string. Not necessarily the exact spelling of a string. Working on the ParaTest switch, I really noticed that we are not doing us the best favor to always test for such exact string/labels (here a little less problematic as it doesn't depend on i18n as in the core). But if you feel it should stay like this, it can ofc.
2 participants
No description provided.