Aispm feature new #104
Open
Aispm feature new #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javelin_cli/_internal/commands.py
Outdated
| javelin_api_key = selected_gateway["api_key_value"] | ||
|
|
||
| # Ensure the API key is set before initializing | ||
| if not javelin_api_key or javelin_api_key == "": |
Contributor
There was a problem hiding this comment.
every gateway will have javelin_api_key. msging here might confuse the user. remove this check.
| security_interval=args.security_interval | ||
| ) | ||
| return client.aispm.create_customer(customer) | ||
|
|
Contributor
There was a problem hiding this comment.
run 'black javelin_cli/_internal/commands.py' on the changes to remove trailing spaces and format the file.
| except Exception as e: | ||
| print(f"Error getting AWS configurations: {e}") | ||
|
|
||
| def delete_aws_config(args): |
Contributor
There was a problem hiding this comment.
pls move impl to service like rest of the methods.
| is_transformation_rules=request.is_transformation_rules, | ||
| is_reload=request.is_reload, | ||
| ) | ||
| if request.route.startswith("v1/admin/aispm"): |
Contributor
There was a problem hiding this comment.
pls move to construct_url fn
| return url, headers | ||
|
|
||
| def _send_request_sync(self, request: Request) -> httpx.Response: | ||
| return self._core_send_request(self.client, request) |
|
|
||
| return url | ||
|
|
||
| def _construct_aispm_url(self, request: Request) -> str: |
Contributor
There was a problem hiding this comment.
not required, since its moving to construct_url
abhijitjavelin
approved these changes
Jan 22, 2025
| is_reload=request.is_reload, | ||
| ) | ||
| if request.route.startswith("v1/admin/aispm"): | ||
| url = f"{self.config.base_url.rstrip('/')}/{request.route}" |
Contributor
There was a problem hiding this comment.
move this logic to contrust_url fn
abhijitjavelin
requested changes
Jan 22, 2025
Contributor
abhijitjavelin
left a comment
abhijitjavelin
left a comment
There was a problem hiding this comment.
pls run 'black .' on files you updated.
move aispm url contruction logic to contrust_url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made commenting the print statements and added new client method for aispm