Add option to specify remote domains for image resizing#820
Open
paulrobertlloyd wants to merge 1 commit intomainfrom
Open
Add option to specify remote domains for image resizing#820paulrobertlloyd wants to merge 1 commit intomainfrom
paulrobertlloyd wants to merge 1 commit intomainfrom
Conversation
|
I will test this out and report back, thank you for adding this feature/option! Edit: I don't know how to test this out, do I have to be on The PR mentions setting a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #814.
Currently the image resizing plugin only supports resizing remote images saved to the destination publication URL (
publication.me). However, it’s possible to configure Indiekit such that files can be saved to other destinations, such as S3-compatible bucket storage.This PR adds a
domainsoption which gets passed to the same option onipxHttpStorage()which controls which remote URLs image resizing is allowed for.For example, if your website is at
https://website.example, but media files are saved tohttps://media.example, you could use the following configuration options: