[SC-4518] Pin Go 1.26.6 so the stdlib CI scans is a patched one - #503
Merged
Conversation
govulncheck failed the security job on five reachable standard library vulnerabilities — net/url resolvePath, crypto/tls post-handshake messages, net/http's unencrypted HTTP/2 check, encoding/asn1 recursion depth, and idna Punycode labels via net/http. All are fixed in go1.26.6 and none has a source-side fix here: the reachable call sites are ordinary http.Client.Do, tls.Conn handshakes and x509.ParseCertificate. Every CI job takes its toolchain from go.mod via setup-go's go-version-file, so the pin is the whole knob. govulncheck now reports nothing reachable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's security job is red on every run:
go tool govulncheck ./...finds five reachable Go standard library vulnerabilities — GO-2026-6218 (net/url), GO-2026-6090 (crypto/tls), GO-2026-6089 (net/http), GO-2026-5972 (encoding/asn1), GO-2026-5026 (idna via net/http). All five are fixed in go1.26.6.Every job resolves its toolchain from go.mod through setup-go's
go-version-file, so thegodirective is the only knob. Bumped 1.26.5 → 1.26.6; govulncheck reports nothing reachable.Failing run: https://github.com/gethuman-sh/human/actions/runs/32117720149